Open
Conversation
2 tasks
majst01
reviewed
Nov 18, 2025
majst01
reviewed
Nov 20, 2025
Contributor
Author
|
@majst01 I added a way of parsing multiple oci configs using Besides, how can I test |
mac641
force-pushed
the
oci-puller
branch
2 times, most recently
from
e053648 to
a5e53cf
Compare
Contributor
Author
|
@majst01 As discussed, this the updated version of the oci pull config where a yaml file is used in order to pass over registry-urls and optional login info. My implementation expects the file to look something like this: oci-configs:
- registry-url: oci://ghcr.io/metal-images/debian:12
username: bla
password: blub
- registry-url: oci://ghcr.io/metal-images/debian:12
username: ""
password: ""
- registry-url: oci://ghcr.io/metal-images/almalinux:9
username: foo
password: barSince we don't have any login info at this point, I have a couple of questions about this:
|
…ferent registries
…configs - mainly to increase readability and overall code quality
vknabel
reviewed
Apr 2, 2026
Comment on lines
+233
to
+257
| metalHammerOciConfigFileContent, err := os.ReadFile(metalHammerOciConfigFilePath) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error retrieving oci configs file: %w", err) | ||
| } | ||
|
|
||
| type MetalHammerOciConfig struct { | ||
| RegistryURL string `yaml:"registry-url"` | ||
| Credentials *api.OciCredentials | ||
| } | ||
| type MetalHammerOciConfigs struct { | ||
| OciConfigs []MetalHammerOciConfig `yaml:"oci-configs"` | ||
| } | ||
| var metalHammerOciConfigs MetalHammerOciConfigs | ||
| err = yaml.Unmarshal(metalHammerOciConfigFileContent, &metalHammerOciConfigs) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error parsing oci configs: %w", err) | ||
| } | ||
|
|
||
| for _, config := range metalHammerOciConfigs.OciConfigs { | ||
| if config.RegistryURL == "" { | ||
| return nil, fmt.Errorf("no registry url specified for oci config: %+v", config) | ||
| } | ||
|
|
||
| ociConfigs[config.RegistryURL] = config.Credentials | ||
| } |
There was a problem hiding this comment.
Would it make sense to put this into a separate function? The getMetalAPIConfig function is pretty long already.
Looks fine though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
References