Merged
Conversation
majst01
commented
Mar 17, 2026
iljarotar
reviewed
Mar 20, 2026
pkg/nftables/nftables_test.go
Outdated
| Prefixes: []string{"10.0.18.0/22"}, | ||
| Ips: []string{"10.0.18.2"}, | ||
| Vrf: 3982, | ||
| // FIXME clarify if this is required |
| Prefixes: []string{"10.0.18.0/22"}, | ||
| Ips: []string{"10.0.18.2"}, | ||
| Vrf: 3982, | ||
| // NatType: apiv2.NATType_NAT_TYPE_IPV4_MASQUERADE, |
| Prefixes: []string{"10.0.18.0/22"}, | ||
| Ips: []string{"10.0.18.2"}, | ||
| Vrf: 3982, | ||
| // NatType: apiv2.NATType_NAT_TYPE_IPV4_MASQUERADE, |
Contributor
|
Maybe we should think about just merging this because this is more or less the "initial commit" for this repository. This would make further reviews much easier. 😅 |
Gerrit91
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on:
This is used in metal-stack/metal-hammer#181
TODO:
NTP and DNS seems not to work as expected, at least for firewalls.