Skip to content

chore: remove redundant ansible.cfg and hide skipped ansible task output#282

Merged
Gerrit91 merged 4 commits intomasterfrom
ansible-output
Apr 1, 2026
Merged

chore: remove redundant ansible.cfg and hide skipped ansible task output#282
Gerrit91 merged 4 commits intomasterfrom
ansible-output

Conversation

@ma-hartma
Copy link
Copy Markdown
Contributor

@ma-hartma ma-hartma commented Mar 16, 2026

With the different flavors of the mini-lab we sometimes have a lot of skipped Ansible tasks, since they're optional.
These all get shown to the user, bloating the terminal output.

This setting change avoids that and only shows running tasks.

As @Gerrit91 mentioned, the ansible.cfg is redundant, as it is included in the base images.
The only overwrite was the handling of (not anymore recommended) RSA keys which I replaced with ed25519 keys.
Instead of ignoring a hyphen in the control-plane group name, it is now called control_plane.

References:

Used AI-Tools ✨

GitHub Copilot was used for research and auto-completion on Gemini 3.1 Pro.

@ma-hartma ma-hartma requested a review from a team as a code owner March 16, 2026 10:08
@ma-hartma ma-hartma changed the title do not display skipped ansible entries do not display skipped ansible tasks Mar 16, 2026
@ma-hartma ma-hartma force-pushed the ansible-output branch 2 times, most recently from 88a1a82 to e25d9a8 Compare March 16, 2026 11:05
@ma-hartma ma-hartma marked this pull request as draft March 16, 2026 11:06
@ma-hartma ma-hartma marked this pull request as ready for review March 27, 2026 13:13
@ma-hartma ma-hartma marked this pull request as draft March 30, 2026 07:38
@ma-hartma ma-hartma marked this pull request as ready for review March 30, 2026 12:54
@ma-hartma
Copy link
Copy Markdown
Contributor Author

@Gerrit91 I removed the ansible.cfg and replaced the RSA key with a ed25519 key to avoid allowing RSA keys.
The force_valid_group_names = ignore parameter was replaced by the following: https://docs.ansible.com/projects/ansible/latest/reference_appendices/config.html#transform-invalid-group-chars in newer Ansible versions.

The problem is that hyphens in group-names are invalid and we need to decide if we:

  1. Rename the control-plane group to control_plane
    OR
  2. Transform invalid group chars automatically.

I'd go for (1), as it is more transparent if we want to debug.
What do you think?

@Gerrit91
Copy link
Copy Markdown
Contributor

Yes, please go for option (1).

@ma-hartma ma-hartma requested a review from Gerrit91 March 30, 2026 14:49
@ma-hartma ma-hartma changed the title do not display skipped ansible tasks chore: remove redundant ansible.cfg and hide skipped ansible task output Mar 30, 2026
@ma-hartma ma-hartma requested a review from Gerrit91 March 31, 2026 06:26
@Gerrit91 Gerrit91 merged commit a37108b into master Apr 1, 2026
7 of 10 checks passed
@Gerrit91 Gerrit91 deleted the ansible-output branch April 1, 2026 10:57
@Gerrit91
Copy link
Copy Markdown
Contributor

Gerrit91 commented Apr 1, 2026

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants