Skip to content

add kamaji flavor#280

Merged
Gerrit91 merged 22 commits intomasterfrom
kamaji
Apr 2, 2026
Merged

add kamaji flavor#280
Gerrit91 merged 22 commits intomasterfrom
kamaji

Conversation

@mac641
Copy link
Copy Markdown
Contributor

@mac641 mac641 commented Feb 26, 2026

Description

Created together with @ma-hartma

References:

Used AI-Tools ✨

GitHub Copilot was used for explaining code, troubleshooting networking issues in the mini-lab and auto-completion.
No substantial parts of commits were generated, as most of the code is based on existing code.

Used models

  • Claude Opus 4.6
  • Gemini 3.1 Pro.

@mac641 mac641 self-assigned this Feb 26, 2026
@mac641 mac641 requested a review from a team as a code owner February 26, 2026 10:48
@ma-hartma ma-hartma marked this pull request as draft March 16, 2026 09:39
@ma-hartma ma-hartma marked this pull request as ready for review March 25, 2026 06:40
@vknabel vknabel requested a review from majst01 April 2, 2026 07:58
@vknabel
Copy link
Copy Markdown
Contributor

vknabel commented Apr 2, 2026

@majst01 fine from my side. The dell_sonic doesn't work in general. Only a contributor review is left now. :)

Copy link
Copy Markdown
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good. But without adding this to the Github Actions and without adding a CODEOWNERS team for this topic, it will break over time and nobody will feel responsible to fix it. You can propose team members and I can create it.

@mac641
Copy link
Copy Markdown
Contributor Author

mac641 commented Apr 2, 2026

@Gerrit91 8b0eb4b contains a CODEOWNERS glob suggestion. As part of the team I suggest @ma-hartma and @mac641.

@ma-hartma
Copy link
Copy Markdown
Contributor

ma-hartma commented Apr 2, 2026

Overall looks really good. But without adding this to the Github Actions and without adding a CODEOWNERS team for this topic, it will break over time and nobody will feel responsible to fix it. You can propose team members and I can create it.

There is now an open issue for the integration tests #287 after discussing this with @mac641 and @vknabel

@Gerrit91 Gerrit91 merged commit c34cb3e into master Apr 2, 2026
4 of 5 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Apr 2, 2026
@Gerrit91 Gerrit91 deleted the kamaji branch April 2, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants