Allow tokenFile instead of raw token#151
Merged
Merged
Conversation
majst01
force-pushed
the
alllow-token-from-file
branch
from
6a9ce8e to
f53d923
Compare
majst01
force-pushed
the
alllow-token-from-file
branch
3 times, most recently
from
071b040 to
de2b665
Compare
majst01
force-pushed
the
alllow-token-from-file
branch
from
de2b665 to
322fec3
Compare
Gerrit91
reviewed
Jul 6, 2026
| if !i.config.tokenFileLastRead.IsZero() { | ||
| // The token is refreshed by a sidecar, this means we should periodically read the tokenfile | ||
| // and store the token in config instead und update the tokenFileLastRead afterwards | ||
| if time.Since(i.config.tokenFileLastRead) < 5*time.Minute { |
Contributor
There was a problem hiding this comment.
const for 5*time.Minute and maybe add an opportunity to overwrite.
Gerrit91
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will allow clients to read the token from a file which will periodically read to be able to have a token refresh sidecar.
Used AI-Tools ✨