Conversation
| string project = 1 [(buf.validate.field).string.uuid = true]; | ||
| // UUID if this field is set, this specific machine will be allocated if it is not in available state and not currently allocated. | ||
| // this field overrules size and partition | ||
| optional string uuid = 2 [(buf.validate.field).string.uuid = true]; |
There was a problem hiding this comment.
This field should be prevented for users and only used for admins.
There was a problem hiding this comment.
done in the apiserver
| string partition = 6 [(buf.validate.field).string.(metalstack.api.v2.is_partition) = true]; | ||
| // Size of the machine to create | ||
| string size = 7 [(buf.validate.field).string = {max_len: 128}]; | ||
| // Partition the partition id to assign this machine to, must be omitted if uuid is given |
There was a problem hiding this comment.
Effectively, this is only optional for admins if they do allocation by UUID.
| // MACHINE_STATE_UNSPECIFIED is not specified | ||
| MACHINE_STATE_UNSPECIFIED = 0 [(enum_string_value) = ""]; | ||
| // MACHINE_STATE_RESERVED this machine is reserved | ||
| // MACHINE_STATE_RESERVED this machine is reserved, e.g. this machine is not considered during machine allocation |
There was a problem hiding this comment.
Maybe there is another term that we can use because this can easily be confused with machine size reservations.
It describes a machine that is not considered during machine allocation --> it's not in the waiting machine pool.
MACHINE_STATE_TAINTED?
| string ip = 1 [(buf.validate.field).string.ip = true]; | ||
| // Namespace where this ip was created, usually the project of the namespaced tenant network. | ||
| optional string namespace = 2 [(buf.validate.field).string.uuid = true]; | ||
| bool no_auto_acquire_ip = 2; |
There was a problem hiding this comment.
Maybe we can think about removing this functionality and just let the users pass IP addresses they want to have on the machine. If they do not provide any IPs, then we do auto acquisition.
3 participants
Description
Contains API enhancements found during metal-apiserver implementation of machine create
Used AI-Tools ✨