Enhance instance setup instructions to handle database connection flow#4
Open
sanex3339 wants to merge 2 commits into
Open
Enhance instance setup instructions to handle database connection flow#4sanex3339 wants to merge 2 commits into
sanex3339 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Metabase setup “skills” documentation to prevent broken MCP OAuth flows by adding stricter gating around instance readiness (especially first-run wizard completion) and by prompting users to optionally connect their own database before handing off to MCP configuration.
Changes:
- Added prominent “read fully / follow exactly” guardrails to both setup skills.
- Enhanced
setup-metabase-mcpinstance validation to include ahas-user-setupreadiness probe and explicit failure-mode handling. - Expanded
setup-metabase-instanceinitialization flow with a background polling Gate 1 and a mandatory Gate 2 prompt to connect a user database before handing off to MCP setup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| skills/setup-metabase-mcp/SKILL.md | Adds stricter pre-OAuth instance readiness validation (version, has-user-setup, /api/mcp response) and clarifies stop/forward behavior. |
| skills/setup-metabase-instance/SKILL.md | Adds a background-poll-based first-run completion gate and a mandatory prompt to optionally connect a user database before MCP handoff. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b82a5db to
6c31253
Compare
6c31253 to
44c0246
Compare
… background polling and user initialization flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

See https://www.loom.com/share/cc327aa4bb2f4f438b7769467d38c86f for some context
Notes:
How to test the Metabase plugin locally
Clone this repo.
Set up a local marketplace that points at the cloned plugin.
Note the
--recursiveflag; you need to copy the directory and its sub-directories because Codex caches a copy of the plugin and won't resolve symlinks when loading local plugins.Then create
~/codex-local/.agents/plugins/marketplace.json:{ "name": "local-dev", "interface": { "displayName": "Local Dev" }, "plugins": [ { "name": "metabase", "source": { "source": "local", "path": "./plugins/metabase" }, "policy": { "installation": "AVAILABLE", "authentication": "ON_INSTALL" }, "category": "Data" } ] }codex plugin marketplace add ~/codex-localOpen Codex and install Metabase from the Local Dev marketplace:
/pluginsslash command.Prepare some local DB with data and its connection string
Ask
Codexsomething likeI want to try metabase and play with my local data.Wait for instance loading, when codex opens the instance setup page - setup instance.
When instance is configured, Codex should auto-detect it and ask if you want to setup a DB connection.
Reply
yes.Codex will open the
DB Connectionssetup page, setup it.Reply
DoneCodex will proceed with MCP setup and after it ask you to start a new thread.
In a new thread ask Codex to show some data from Metabase and your newly added DB