Skip to content

make api docs load only required styles files#1193

Open
tmashara wants to merge 1 commit into
masterfrom
fix-api-docs-styles
Open

make api docs load only required styles files#1193
tmashara wants to merge 1 commit into
masterfrom
fix-api-docs-styles

Conversation

@tmashara

@tmashara tmashara commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

closes https://linear.app/metabase/issue/GRO-502/fix-unreadable-api-docs-endpoint-titles-in-dark-mode

related PR: https://github.com/metabase/metabase.github.io/pull/5973

changes: removed redundant styles for dark-mode, prevent loading main website css styles conflicting with the scalar styles

BEFORE AFTER
image image
Screenshot 2026-06-24 at 10 12 54 image
Screenshot 2026-06-24 at 10 14 46 image

@tmashara tmashara requested review from a team and alexyarosh June 24, 2026 08:17

@alexyarosh alexyarosh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bpander bpander left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Fix makes sense. The text color issue (which prompted this issue) seemed to have fixed itself, although there were definitely styles bleeding into the docs-api pages like comically large headings in the "Test request" modal. Verified those issues were fixed on docs-api without affecting the rest of the docs pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants