-
Notifications
You must be signed in to change notification settings - Fork 114
Restore test_controller #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Restore test_controller #2013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought all the tests in here were things related specific to the old rust controller because the first few were. But there are real tensor engine tests in here. So I put them back Differential Revision: [D87955377](https://our.internmc.facebook.com/intern/diff/D87955377/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 26, 2025
I thought all the tests in here were things related specific to the old rust controller because the first few were. But there are real tensor engine tests in here. So I put them back Differential Revision: [D87955377](https://our.internmc.facebook.com/intern/diff/D87955377/) ghstack-source-id: 325854076 Pull Request resolved: #2013
I thought all the tests in here were things related specific to the old rust controller because the first few were. But there are real tensor engine tests in here. So I put them back Differential Revision: [D87955377](https://our.internmc.facebook.com/intern/diff/D87955377/) [ghstack-poisoned]
This was referenced Nov 26, 2025
Closed
I thought all the tests in here were things related specific to the old rust controller because the first few were. But there are real tensor engine tests in here. So I put them back Differential Revision: [D87955377](https://our.internmc.facebook.com/intern/diff/D87955377/) [ghstack-poisoned]
I thought all the tests in here were things related specific to the old rust controller because the first few were. But there are real tensor engine tests in here. So I put them back Differential Revision: [D87955377](https://our.internmc.facebook.com/intern/diff/D87955377/) [ghstack-poisoned]
I thought all the tests in here were things related specific to the old rust controller because the first few were. But there are real tensor engine tests in here. So I put them back Differential Revision: [D87955377](https://our.internmc.facebook.com/intern/diff/D87955377/) [ghstack-poisoned]
I thought all the tests in here were things related specific to the old rust controller because the first few were. But there are real tensor engine tests in here. So I put them back Differential Revision: [D87955377](https://our.internmc.facebook.com/intern/diff/D87955377/) [ghstack-poisoned]
I thought all the tests in here were things related specific to the old rust controller because the first few were. But there are real tensor engine tests in here. So I put them back Differential Revision: [D87955377](https://our.internmc.facebook.com/intern/diff/D87955377/) [ghstack-poisoned]
I thought all the tests in here were things related specific to the old rust controller because the first few were. But there are real tensor engine tests in here. So I put them back Differential Revision: [D87955377](https://our.internmc.facebook.com/intern/diff/D87955377/) [ghstack-poisoned]
|
This pull request has been merged in ee42dc1. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I thought all the tests in here were things related specific to the old rust controller because the first few were. But there are real tensor engine tests in here. So I put them back
Differential Revision: D87955377