remote rust_local_mesh #1947
Closed
remote rust_local_mesh #1947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/) [ghstack-poisoned]
This was referenced Nov 19, 2025
zdevito
added a commit
that referenced
this pull request
Nov 20, 2025
Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/) ghstack-source-id: 324556858 Pull Request resolved: #1947
meta-cla
bot
added
the
CLA Signed
Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 20, 2025
This diff removes the old way we created tensor engines via rust local mesh. We were no longer testing this in test_remote_functions, etc. but still have a bunch of old examples that depended on it. The reason to do this now is to lighten what we actually use in the monarch_tensor_worker crate. We need to sever its direct dependence on torch and getting rid of its dead code makes it clearer what we have to do. Pull Request resolved: #1947 Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/) ghstack-source-id: 324728297
Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 20, 2025
This diff removes the old way we created tensor engines via rust local mesh. We were no longer testing this in test_remote_functions, etc. but still have a bunch of old examples that depended on it. The reason to do this now is to lighten what we actually use in the monarch_tensor_worker crate. We need to sever its direct dependence on torch and getting rid of its dead code makes it clearer what we have to do. Pull Request resolved: #1947 ghstack-source-id: 324737962 Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/)
Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 20, 2025
This diff removes the old way we created tensor engines via rust local mesh. We were no longer testing this in test_remote_functions, etc. but still have a bunch of old examples that depended on it. The reason to do this now is to lighten what we actually use in the monarch_tensor_worker crate. We need to sever its direct dependence on torch and getting rid of its dead code makes it clearer what we have to do. Pull Request resolved: #1947 ghstack-source-id: 324781240 Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/)
Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 20, 2025
This diff removes the old way we created tensor engines via rust local mesh. We were no longer testing this in test_remote_functions, etc. but still have a bunch of old examples that depended on it. The reason to do this now is to lighten what we actually use in the monarch_tensor_worker crate. We need to sever its direct dependence on torch and getting rid of its dead code makes it clearer what we have to do. Pull Request resolved: #1947 ghstack-source-id: 324782599 Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/)
Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 20, 2025
This diff removes the old way we created tensor engines via rust local mesh. We were no longer testing this in test_remote_functions, etc. but still have a bunch of old examples that depended on it. The reason to do this now is to lighten what we actually use in the monarch_tensor_worker crate. We need to sever its direct dependence on torch and getting rid of its dead code makes it clearer what we have to do. Pull Request resolved: #1947 ghstack-source-id: 324784234 Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/)
Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 20, 2025
This diff removes the old way we created tensor engines via rust local mesh. We were no longer testing this in test_remote_functions, etc. but still have a bunch of old examples that depended on it. The reason to do this now is to lighten what we actually use in the monarch_tensor_worker crate. We need to sever its direct dependence on torch and getting rid of its dead code makes it clearer what we have to do. Pull Request resolved: #1947 ghstack-source-id: 324814292 Differential Revision: [D87496994](https://our.internmc.facebook.com/intern/diff/D87496994/)
This was referenced Nov 21, 2025
|
This pull request has been merged in a736b7e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D87496994