dedup code related to tail_str in spawn_exit_monitor #1922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: meta-pytorch#1914 Reviewed By: mariusae, vidhyav Differential Revision: D87269409
Summary: As title. Reviewed By: mariusae Differential Revision: D87274098
Summary:
This block is duplicated in 4 if-else branches:
```
let tail_str = if stderr_tail.is_empty() {
None
} else {
Some(stderr_tail.join("\n"))
};
```
This diff extracts it out and log it in the `tail` field.
Differential Revision: D87344528
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 244c892. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This block is duplicated in 4 if-else branches:
This diff extracts it out and log it in the
tailfield.Differential Revision: D87344528