log endpoint name when supervision error happens #1917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
moonli
force-pushed
the
export-D87353113
branch
2 times, most recently
from
bceb874 to
9073454
Compare
…ytorch#1917) Summary: The current error message logs the actor name and stacktrace when an exception happens (ActorError/SupervisionError). The endpoint name is included in the stacktrace. But for cases like proc crash, the supervision error doesn't have a stacktrace, so it couldn't show the endpoint name. This diff includes the user actor name and endpoint name to the exceptions ActorError and SupervisionError. github issue: meta-pytorch#1899 Differential Revision: D87353113
moonli
force-pushed
the
export-D87353113
branch
from
9073454 to
e54e77c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The current error message logs the actor name and stacktrace when an exception happens (ActorError/SupervisionError). The endpoint name is included in the stacktrace.
But for cases like proc crash, the supervision error doesn't have a stacktrace, so it couldn't show the endpoint name.
This diff adds a error log message that proceeds the supervision error, it will print both the actor name and endpoint name of the call. It is very useful for users to figure out where the failure happened in all error cases.
Differential Revision: D87353113