[hyperactor] telemetry: don't record net i/o loop spans in scuba #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used primarily to provide context for any logged events, and should not be recorded as separate spans in scuba. We introduce a general mechanism, exposing the key `hyperactor_telemetry::skip_record` which, if included in a span, causes the downstream scuba subscribe to skip recording the span as its own discrete event. This also prevents us from entering and exiting the spans accordingly. We do maintain the recorded fields, which provide important context; they continue to propagate to the individually recorded entries. Differential Revision: [D87273700](https://our.internmc.facebook.com/intern/diff/D87273700/) [ghstack-poisoned]
meta-cla
bot
added
the
CLA Signed
… scuba" These are used primarily to provide context for any logged events, and should not be recorded as separate spans in scuba. We introduce a general mechanism, exposing the key `hyperactor_telemetry::skip_record` which, if included in a span, causes the downstream scuba subscribe to skip recording the span as its own discrete event. This also prevents us from entering and exiting the spans accordingly. We do maintain the recorded fields, which provide important context; they continue to propagate to the individually recorded entries. Differential Revision: [D87273700](https://our.internmc.facebook.com/intern/diff/D87273700/) [ghstack-poisoned]
… scuba" These are used primarily to provide context for any logged events, and should not be recorded as separate spans in scuba. We introduce a general mechanism, exposing the key `hyperactor_telemetry::skip_record` which, if included in a span, causes the downstream scuba subscribe to skip recording the span as its own discrete event. This also prevents us from entering and exiting the spans accordingly. We do maintain the recorded fields, which provide important context; they continue to propagate to the individually recorded entries. Differential Revision: [D87273700](https://our.internmc.facebook.com/intern/diff/D87273700/) [ghstack-poisoned]
… scuba" These are used primarily to provide context for any logged events, and should not be recorded as separate spans in scuba. We introduce a general mechanism, exposing the key `hyperactor_telemetry::skip_record` which, if included in a span, causes the downstream scuba subscribe to skip recording the span as its own discrete event. This also prevents us from entering and exiting the spans accordingly. We do maintain the recorded fields, which provide important context; they continue to propagate to the individually recorded entries. Differential Revision: [D87273700](https://our.internmc.facebook.com/intern/diff/D87273700/) [ghstack-poisoned]
… scuba" These are used primarily to provide context for any logged events, and should not be recorded as separate spans in scuba. We introduce a general mechanism, exposing the key `hyperactor_telemetry::skip_record` which, if included in a span, causes the downstream scuba subscribe to skip recording the span as its own discrete event. This also prevents us from entering and exiting the spans accordingly. We do maintain the recorded fields, which provide important context; they continue to propagate to the individually recorded entries. Differential Revision: [D87273700](https://our.internmc.facebook.com/intern/diff/D87273700/) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These are used primarily to provide context for any logged events, and should not be recorded as separate spans in scuba.
We introduce a general mechanism, exposing the key
hyperactor_telemetry::skip_recordwhich, if included in a span, causes the downstream scuba subscribe to skip recording the span as its own discrete event. This also prevents us from entering and exiting the spans accordingly.We do maintain the recorded fields, which provide important context; they continue to propagate to the individually recorded entries.
Differential Revision: D87273700