: set mesh logging defaults for notebooks #1893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87098535. |
shayne-fletcher
force-pushed
the
export-D87098535
branch
from
b486ea5 to
c9871f0
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 17, 2025
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Differential Revision: D87098535
shayne-fletcher
force-pushed
the
export-D87098535
branch
from
c9871f0 to
d5bcca1
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 17, 2025
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Differential Revision: D87098535
shayne-fletcher
force-pushed
the
export-D87098535
branch
from
d5bcca1 to
23912ca
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 17, 2025
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Differential Revision: D87098535
shayne-fletcher
force-pushed
the
export-D87098535
branch
from
23912ca to
190a815
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 17, 2025
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Differential Revision: D87098535
shayne-fletcher
force-pushed
the
export-D87098535
branch
from
190a815 to
c41c14e
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 17, 2025
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Reviewed By: mariusae Differential Revision: D87098535
shayne-fletcher
force-pushed
the
export-D87098535
branch
from
c41c14e to
4a7e42c
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 17, 2025
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Reviewed By: mariusae Differential Revision: D87098535
shayne-fletcher
force-pushed
the
export-D87098535
branch
2 times, most recently
from
fae9447 to
bb63757
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 18, 2025
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Reviewed By: mariusae Differential Revision: D87098535
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 18, 2025
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Reviewed By: mariusae Differential Revision: D87098535
shayne-fletcher
force-pushed
the
export-D87098535
branch
from
bb63757 to
12cb488
Compare
Summary: this diff fixes incorrect overwrite semantics in the python configuration path. previously, each kwarg passed to `configure()` called `global::set(Source::Runtime, …)`, which replaces the entire `Runtime` layer. as a result, setting multiple keys in separate calls-or even within a single call-would drop previously set `Runtime` values. the fix introduces `Attrs::merge` and `global::create_or_merge`, which perform an in‑place update of an existing layer while preserving keys not mentioned in the update. the python bridge now uses `create_or_merge` instead of `set`, giving `Runtime` the incremental semantics expected by the python API. a shared `make_layer` helper removes duplicated construction logic. python‑exposed config keys for log forwarding and capture are enabled, and new tests in rust and python exercise single and multi-key configuration. Reviewed By: mariusae Differential Revision: D87339094
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Reviewed By: mariusae Differential Revision: D87098535
shayne-fletcher
force-pushed
the
export-D87098535
branch
from
12cb488 to
fa1d98f
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 19, 2025
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Reviewed By: mariusae Differential Revision: D87098535
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 19, 2025
Summary: D86994420 changed defaults: - `HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=false` - `HYPERACTOR_MESH_ENABLE_FILE_CAPTURE=false` - `HYPERACTOR_MESH_TAIL_LOG_LINES=0` these defaults do not play well with interactive notebooks so this diff selectively overrides them when the execution environment is interactive (ipython, jupyter, bento). incidentally this diff adds a new test module `test_actor_logging.py`. today it has a new smoke test, in time i mean to break out the logging tests from `test_python_actor.py`, fix those that need it, and move them here. Reviewed By: mariusae Differential Revision: D87098535
|
This pull request has been merged in ed514e4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D86994420 changed defaults:
HYPERACTOR_MESH_ENABLE_LOG_FORWARDING=falseHYPERACTOR_MESH_ENABLE_FILE_CAPTURE=falseHYPERACTOR_MESH_TAIL_LOG_LINES=0these defaults do not play well with interactive notebooks so this diff selective overrides them when the execution environment is determined to be interactive.
Differential Revision: D87098535