[2/N] Autobucketing: add estimation utils for autobucketing #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
This was referenced Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds runtime estimation for autobucketing.
The comm/comp estimation code is taken from this pr: pytorch/pytorch#157572. There is an on-going effort to integrate the estimation to PyTorch: pytorch/pytorch#161405.
I'm trying to make this autobucketing pass working without any on-going dependencies, such that ppl can use it out of box. The actual estimation code is located in
estimation_utils.py, which should be updated once we finalize a plan to consolidate all estimation efforts.Stack from ghstack (oldest at bottom):