Skip to content

remove dist *_pb files - #1402

Open
JonathanMH wants to merge 1 commit into
meshtastic:mainfrom
JonathanMH:chore/remove-ignored-protobuf-ts-files
Open

remove dist *_pb files#1402
JonathanMH wants to merge 1 commit into
meshtastic:mainfrom
JonathanMH:chore/remove-ignored-protobuf-ts-files

Conversation

@JonathanMH

@JonathanMH JonathanMH commented Aug 16, 2026

Copy link
Copy Markdown

Description

Removes the ts/dist files that are generated from the protobuf schema as indicated in the .gitignore

Edit: It's my first time setting up the repo so, please let me know if I'm just holding it wrong, but I think these are build errors that make the setup harder for first time contributions. Thank you so much for your awesome work here!

Edit 2: Also possibly desired behaviour according to: https://github.com/meshtastic/web/pull/1280/changes#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

Changes Made

Ran git rm -r --cached packages/protobufs/packages/ts/dist to not pollute the git history with changes like below on every build

diff --git a/packages/protobufs/packages/ts/dist/meshtastic/apponly_pb.ts b/packages/protobufs/packages/ts/dist/meshtastic/apponly_pb.ts
index 2b3aee64..b7aaa2c9 100644
--- a/packages/protobufs/packages/ts/dist/meshtastic/apponly_pb.ts
+++ b/packages/protobufs/packages/ts/dist/meshtastic/apponly_pb.ts
@@ -1,4 +1,4 @@
-// @generated by protoc-gen-es v2.12.0 with parameter "target=ts"
+// @generated by protoc-gen-es v2.14.0 with parameter "target=ts"
 // @generated from file meshtastic/apponly.proto (package meshtastic, syntax proto3)

@vercel

vercel Bot commented Aug 16, 2026

Copy link
Copy Markdown

@JonathanMH is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

CLAassistant commented Aug 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (26)
  • packages/protobufs/packages/ts/dist/meshtastic/admin_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/apponly_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/atak_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/cannedmessages_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/channel_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/clientonly_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/config_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/connection_status_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/device_ui_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/deviceonly_legacy_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/deviceonly_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/interdevice_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/localonly_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/mesh_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/module_config_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/mqtt_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/paxcount_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/portnums_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/powermon_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/remote_hardware_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/rtttl_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/serial_hal_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/storeforward_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/telemetry_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/meshtastic/xmodem_pb.ts is excluded by !**/dist/**
  • packages/protobufs/packages/ts/dist/nanopb_pb.ts is excluded by !**/dist/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0bb04105-9eee-47ec-b5b5-75391c555034

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants