Skip to content

Update default theme path export - #1401

Open
JonathanMH wants to merge 1 commit into
meshtastic:mainfrom
JonathanMH:fix/update-default-theme-path
Open

Update default theme path export#1401
JonathanMH wants to merge 1 commit into
meshtastic:mainfrom
JonathanMH:fix/update-default-theme-path

Conversation

@JonathanMH

@JonathanMH JonathanMH commented Aug 16, 2026

Copy link
Copy Markdown

Description

Edit: It's my first time setting up the repo so, please let me know if I'm just holding it wrong, but I think these are build errors that make the setup harder for first time contributions. Thank you so much for your awesome work here!

Edit 2: I saw that #1280 exists, which might be the better solution

Prior to the update to the UI package, cloning the repo from main and trying to build would result in:

packages/ui build$ vite build && publint                                                                                                                                                                                                                                                  
│ vite v8.1.5 building client environment for production...                                                                                                                                                                                                                               
                                                                                                                                                                                                                                                                                          
│ transforming...✓ 1865 modules transformed.                                                                                                                                                                                                                                              
│ rendering chunks...                                                                                                                                                                                                                                                                     
│ [unplugin:dts] Start generate declaration files...                                                                                                                                                                                                                                      
│ [unplugin:dts] Declaration files built in 1161ms.                                                                                                                                                                                                                                       
│ [vite-plugin-static-copy] Copied 1 items.                                                                                                                                                                                                                                               
│ computing gzip size...                                                                                                                                                                                                                                                                  
│ dist/index.js  177.42 kB │ gzip: 49.69 kB │ map: 581.69 kB                                                                                                                                                                                                                              
│ ✓ built in 1.26s                                                                                                                                                                                                                                                                        
│ Running publint v0.3.22 for @meshtastic/ui...                                                                                                                                                                                                                                           
│ Packing files with `pnpm pack`...                                                                                                                                                                                                                                                       
│ Linting...                                                                                                                                                                                                                                                                              
│ Errors:                                                                                                                                                                                                                                                                                 
│ 1. pkg.exports["./theme/default.css"] is ./dist/theme/default.css but the file does not exist.                                                                                                                                                                                          
└─ Failed in 2.4s at /home/jonathan/projects/meshtastic-web/packages/ui                                                                                                                                                                                                                   
/home/jonathan/projects/meshtastic-web/packages/ui:                                                                                                                                                                                                                                       
[ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL] @meshtastic/ui@0.1.0 build: `vite build && publint`                                                                                                                                                                                                   
Exit status 1                                                                                                                                                                                                                                                                             
pnpm -r build  5,52s user 0,86s system 195% cpu 3,268 total    

Changes Made

Update to the export path of the ui package in the package.json.

Testing Done

Build now passes with:

packages/ui build$ vite build && publint
[4 lines collapsed]
│ [unplugin:dts] Start generate declaration files...
│ [unplugin:dts] Declaration files built in 981ms.
│ [vite-plugin-static-copy] Copied 1 items.
│ computing gzip size...
│ dist/index.js  177.42 kB │ gzip: 49.69 kB │ map: 581.69 kB
│ ✓ built in 1.06s
│ Running publint v0.3.22 for @meshtastic/ui...
│ Packing files with `pnpm pack`...
│ Linting...
│ All good!
  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All i18n translation labels have been added (read
    CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)

Summary by CodeRabbit

  • Bug Fixes
    • Fixed the default theme stylesheet export so the correct styling is applied when imported.

@vercel

vercel Bot commented Aug 16, 2026

Copy link
Copy Markdown

@JonathanMH is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

CLAassistant commented Aug 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 10502bd0-2982-400f-bb33-d40ebd2f867c

📥 Commits

Reviewing files that changed from the base of the PR and between 1db40fe and 02a5610.

📒 Files selected for processing (1)
  • packages/ui/package.json

Included review availability: Your plan includes up to 4 reviews per rolling hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The UI package updates the default theme CSS export to reference its nested distribution path.

Changes

UI theme export

Layer / File(s) Summary
Update default theme CSS export
packages/ui/package.json
The ./theme/default.css export now points to ./dist/theme/src/lib/theme/default.css.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 02a56

This localized package metadata change corrects the default theme stylesheet export and the package build now passes validation; no actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit checks the theme path,
CSS hops along its track.
The nested file is now in sight,
Default colors land just right.
One small change, and off I dash!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change to the default theme export path.
Description check ✅ Passed The description explains the build problem, identifies the change, reports successful testing, and includes the checklist.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants