Update default theme path export - #1401
Conversation
|
@JonathanMH is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 4 reviews per rolling hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe UI package updates the default theme CSS export to reference its nested distribution path. ChangesUI theme export
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized package metadata change corrects the default theme stylesheet export and the package build now passes validation; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Edit: It's my first time setting up the repo so, please let me know if I'm just holding it wrong, but I think these are build errors that make the setup harder for first time contributions. Thank you so much for your awesome work here!
Edit 2: I saw that #1280 exists, which might be the better solution
Prior to the update to the UI package, cloning the repo from main and trying to build would result in:
Changes Made
Update to the export path of the ui package in the
package.json.Testing Done
Build now passes with:
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)
Summary by CodeRabbit