Protocol parser fixes and ASAN - #3524
Closed
neilalexander wants to merge 1 commit into
Closed
neilalexander wants to merge 1 commit into
neilalexander wants to merge 1 commit into
Conversation
A number of severe problems existed in the protocol parser: * Null/out-of-bounds reads in `Packet::readFrom` for empty or truncated frames * Unsafe logic duplicated into `Dispatcher::tryParsePacket` * Short typed payloads could expose stale/uninitialised memory * Partial AES ciphertext could cause block-sized overreads * Decrypted PATH payloads could advance beyond their valid length * Invalid TRACE packets, zero-hop CONTROL routes and oversized advert data were accepted * `AdvertDataParser::AdvertDataParser` failed to reject null, empty, oversized, truncated inputs * Multi-ack overflow in plain and multipart ACKs outside of supported byte ranges * Anonymous reply path overread without considering decrypted length These are now fixed, along with added tests and ASAN testing target.
Contributor
Author
|
Apologies, was trying to open the PR on my own fork to check CI and hit the wrong base repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of severe problems existed in the protocol parser:
Packet::readFromfor empty or truncated framesDispatcher::tryParsePacketAdvertDataParser::AdvertDataParserfailed to reject null, empty, oversized, truncated inputsThese are now fixed, along with added tests and ASAN testing target.