fix(repeater): prevent stack overflow out of RX handler - #3196
Open
benallfree wants to merge 1 commit into
Open
Conversation
Remote admin CLI no longer runs handleCommand inside onPeerDataRecv. Commands queue to MyMesh::loop() so savePrefs and ed25519_sign run at loop-task stack depth, matching USB serial CLI. Co-authored-by: Cursor <cursoragent@cursor.com>
benallfree
changed the title
benallfree
marked this pull request as ready for review
August 13, 2026 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team, this is a bug I stumbled across as I was customizing the firmware and noticed a stack overflow happening in an advert action from a remote admin UI. It is not reproducible on the stock firmware, but the bug/potential is there nonetheless.
It can be fixed by queuing remote commands and executing them as part of the loop instead of handling them inline.