Add initial support for M5Stack Cardputer ADV with Cap LoRa-1262#2457
Open
kucharz96 wants to merge 50 commits intomeshcore-dev:devfrom
Open
Add initial support for M5Stack Cardputer ADV with Cap LoRa-1262#2457kucharz96 wants to merge 50 commits intomeshcore-dev:devfrom
kucharz96 wants to merge 50 commits intomeshcore-dev:devfrom
Conversation
WIP: Restore Cardputer ADV port on ui-new base
Cardputer UI new port
Cardputer rf diagnostics
Cardputer rf diagnostics
Removed links to outdated resources and links
Removed links to outdated resources and links
Update script link in FAQ 4.7 to the repo of the fork
…oard-support Add LilyGo T-ETH Elite SX1262 board support
Author
|
Closes #2458 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds initial support for M5Stack Cardputer ADV used with M5Stack Cap LoRa-1262.
The goal of this PR is to upstream a minimal, reviewable hardware bring-up path for this device combination, without changing MeshCore protocol behavior, routing, BLE logic, or UI behavior.
What this PR changes
This PR introduces two focused hardware-related adjustments for the Cardputer ADV LoRa path:
LoRa cap IO expander / RF path initialization
0x43IO expander setup so that only the required output is enabledSX1262 PA configuration after successful radio initialization
std_init()completes successfullyMotivation
At the time of opening this PR, the official MeshCore tree does not provide dedicated support for M5Stack Cardputer ADV.
During real-device bring-up and testing with Cardputer ADV + Cap LoRa-1262, the radio could initialize and operate, but RF behavior was not as consistent as expected compared with hardware-specific builds tested on the same platform.
The most likely cause appeared to be in the low-level hardware bring-up path for the LoRa cap, especially around expander-based initialization and RF control, rather than in MeshCore application logic.
Scope
This PR is intentionally narrow in scope.
It does not include:
The intent is to keep the first upstream Cardputer ADV submission small and easy to review.
Files changed
variants/m5stack_cardputer/M5CardputerBoard.hvariants/m5stack_cardputer/target.cppHardware used for testing
Notes for review
This should be considered initial support rather than a final, fully validated implementation.
Feedback would be especially appreciated on:
m5stack_cardputervariant path or be split into more explicit ADV-specific handlingClosing
The main purpose of this PR is to start upstream support for M5Stack Cardputer ADV and open the discussion with maintainers using a small, hardware-focused patch set.
Thanks for reviewing.