Skip to content

Check to see if a message was received should happen before RX queue delay #1385

Closed as not planned

Description

@weebl2000

Looking at the code, I believe we are currently checking if a packet has been seen when it is processed. For packets with bad signal we use an RX queue that can have packets wait for 32 second at most. I believe this might be aiding in in unwanted retransmits, especially on busy nodes.

Also see #1380 as possible mitigation. But aside from that, I think we should mark packets as seen as soon as they come in, not when they are being processed after the delay.

Thoughts?

Activity

  1. changed the title [-]Check to see if a message was received should happen before RX queue[/-] [+]Check to see if a message was received should happen before RX queue delay[/+] on Jan 13, 2026
  2. oltaco commented on Jan 16, 2026

    @oltaco
    Member

    Are you able to explain a bit more what you mean? Maybe link to the part of the code you are referring to?

  3. weebl2000 commented on Feb 27, 2026

    @weebl2000
    ContributorAuthor

    Are you able to explain a bit more what you mean? Maybe link to the part of the code you are referring to?

    Sorry for the radio silence, please see PR #1380. It doesn't fix this issue entirely but it's a step in the right direction.

    What I was actually referring to was that if rxdelay is set to a value larger than 0, it is possible for this situation to occur:

    1. Packet with hash HASH1 received by node X
    2. Packet with hash HASH1 (identical) received by node Y with very bad signal strength, high txdelay -> packet is queued internally by some time (20 seconds max iirc?)
    3. Other messages arrive
    4. Packet received in step 2 is processed, but enough messages arrived in the mean time that we have forgotten about 1, the packet with HASH1 received by node X.

    So ideally, to fix this, before queuing the processing of packet received in step 2, we would drop it immediately if we have it in our cache already.

    I think the scenario isn't very likely unless you are an extremely busy node and have rxdelay set to >=0.

    I hope this clears up the issue I tried to address.

  4. github-actions commented on Jul 9, 2026

    @github-actions
    Contributor

    This issue is stale because it has been open for 60 days with no activity. Remove the stale label or add a comment if this issue is still relevant, otherwise this issue will automatically close in 7 days.

  5. github-actions commented on Aug 29, 2026

    @github-actions
    Contributor

    This issue was closed because it has been inactive for 7 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions