Skip to content

[WC-3512] fix(dropdown-sort-web): prevent React warnings from uncontrolled input #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iobuhov wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

[WC-3512] fix(dropdown-sort-web): prevent React warnings from uncontrolled input #2393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/dropdown-sort-web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- We fixed React console warnings from uncontrolled input elements.

## [3.4.0] - 2025-10-01

### Fixed
Expand Down
6 changes: 3 additions & 3 deletions packages/pluggableWidgets/dropdown-sort-web/src/components/SortComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { useOnClickOutside } from "@mendix/widget-plugin-hooks/useOnClickOutside";
import { usePositionObserver } from "@mendix/widget-plugin-hooks/usePositionObserver";
import classNames from "classnames";
import { CSSProperties, ReactElement, useCallback, useRef, useState } from "react";
import { createPortal } from "react-dom";
import { useOnClickOutside } from "@mendix/widget-plugin-hooks/useOnClickOutside";
import { usePositionObserver } from "@mendix/widget-plugin-hooks/usePositionObserver";

interface SortComponentProps<Dir = "asc" | "desc"> {
className?: string;
Expand Down Expand Up @@ -105,7 +105,7 @@ export function SortComponent(props: SortComponentProps): ReactElement {
>
<div className="dropdown-triggerer-wrapper">
<input
value={props.value ? selected?.caption : ""}
value={selected?.caption ?? ""}
placeholder={props.placeholder}
className="form-control dropdown-triggerer"
onClick={containerClick}
Expand Down
Loading