Skip to content

[MOO-2428] : Align dependency versions and pin every version in widgets 11-12-x - #606

Open
saurabhchavan1711 wants to merge 10 commits into
mx/11.12.xfrom
moo/MOO-2428-align-dependency-versions-and-pin-every-version-11-12-x
Open

[MOO-2428] : Align dependency versions and pin every version in widgets 11-12-x#606
saurabhchavan1711 wants to merge 10 commits into
mx/11.12.xfrom
moo/MOO-2428-align-dependency-versions-and-pin-every-version-11-12-x

Conversation

@saurabhchavan1711

@saurabhchavan1711 saurabhchavan1711 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Contains unit tests ✅
  • Contains breaking changes ❌
  • Compatible with: MX 11
  • Did you update version and changelog? ✅
  • PR title properly formatted ([XX-000]: description)? ✅
  • Works in Android ✅
  • Works in iOS ✅
  • Works in Tablet ✅

Feature specific

  • Comply with designs ✅
  • Comply with PM's requirements ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

This PR -

  • Aligned the dependency versions to use exact version for same library used in different widgets
  • Removed the range specifiers from widgets package.json and pnpm-lock.yaml to pin exact version , so that we can only update those from PR intentionally.
  • Fixed this issue of rating widget icons not visible when user does not selects any icon for selected and empty rating icons in SP

@saurabhchavan1711
saurabhchavan1711 requested a review from a team as a code owner August 19, 2026 12:29

@MxKevinBeqo MxKevinBeqo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth checking also if the maestro screenshot comparison should be updated or not. I know they passed, but just to ensure that it did not pass because of the 5% image comparison tolerance.

Mainly suspicious about the Empty Star Icon, because in the rating.png it does not render an icon at all.

Comment thread packages/pluggableWidgets/rating-native/src/Rating.tsx Outdated
@saurabhchavan1711

Copy link
Copy Markdown
Contributor Author

Yes @MxKevinBeqo , Good point . I tried by replacing the rating widget with this change locally and we indeed need to update the screenshot because now it will contain stars for empty icons. Current screenshot also proves that when empty icon set to none does not display anything on the screen which we fixed in this PR.

I think we don't have to look at other widgets because there are no UI changes in those and also we only replaced the dependency versions that are currently used in pnpm-lock.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants