[MOO-2428] : Align dependency versions and pin every version in widgets 11-12-x - #606
Conversation
MxKevinBeqo
left a comment
There was a problem hiding this comment.
Worth checking also if the maestro screenshot comparison should be updated or not. I know they passed, but just to ensure that it did not pass because of the 5% image comparison tolerance.
Mainly suspicious about the Empty Star Icon, because in the rating.png it does not render an icon at all.
|
Yes @MxKevinBeqo , Good point . I tried by replacing the rating widget with this change locally and we indeed need to update the screenshot because now it will contain stars for empty icons. Current screenshot also proves that when empty icon set to none does not display anything on the screen which we fixed in this PR. I think we don't have to look at other widgets because there are no UI changes in those and also we only replaced the dependency versions that are currently used in pnpm-lock.yaml. |
Checklist
[XX-000]: description)? ✅Feature specific
This PR contains
What is the purpose of this PR?
This PR -