Skip to content

[MOO-2364] Update to hermes-compiler v1 #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MxKevinBeqo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[MOO-2364] Update to hermes-compiler v1 #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca6d1c2
chore: switch to hermes-compiler v1; update Podfile.lock
MxKevinBeqo Jun 29, 2026
8831b0c
chore: update Podfile.lock
MxKevinBeqo Jun 30, 2026
afb6c2e
revert: enableOnBackInvokedCallback in AndroidManifest
MxKevinBeqo Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
android:largeHeap="true"
android:theme="@style/AppTheme"
android:requestLegacyExternalStorage="true"
android:enableOnBackInvokedCallback="true"
tools:ignore="GoogleAppIndexingWarning">
<activity
android:name="com.mendix.nativetemplate.MainActivity"
Expand Down
2 changes: 1 addition & 1 deletion android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ android.nonTransitiveRClass=true
android.suppressUnsupportedCompileSdk=33
newArchEnabled=true
hermesEnabled=true
hermesV1Enabled=false
hermesV1Enabled=true
mendixnative.cookieEncryption=false
VisionCamera_enableCodeScanner=true

Expand Down
3 changes: 0 additions & 3 deletions ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ ENV['RCT_NEW_ARCH_ENABLED'] = '1'
ENV['RCT_USE_PREBUILT_RNCORE'] = '1'
ENV['RCT_USE_RN_DEP'] = '1'

# The JS bundle is compiled compiled using a different version than the prebuilt Hermes engine embedded in the native binary, causing a runtime crash.
ENV['RCT_HERMES_V1_ENABLED'] = '0'

# Use it to require both react-native's and this package's scripts:
node_require('react-native/scripts/react_native_pods.rb')
node_require('react-native-permissions/scripts/setup.rb')
Expand Down
14 changes: 7 additions & 7 deletions ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PODS:
- FBLazyVector (0.84.1)
- hermes-engine (0.15.1):
- hermes-engine/Pre-built (= 0.15.1)
- hermes-engine/Pre-built (0.15.1)
- hermes-engine (250829098.0.9):
- hermes-engine/Pre-built (= 250829098.0.9)
- hermes-engine/Pre-built (250829098.0.9)
- IQKeyboardManager (6.5.19)
- libavif/core (0.11.1)
- libavif/libdav1d (0.11.1):
Expand Down Expand Up @@ -2666,7 +2666,7 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native/Libraries/FBLazyVector"
hermes-engine:
:podspec: "../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec"
:tag: hermes-v0.15.1
:tag: hermes-v250829098.0.9
MendixNative:
:path: "../node_modules/mendix-native"
op-sqlite:
Expand Down Expand Up @@ -2862,7 +2862,7 @@ EXTERNAL SOURCES:

SPEC CHECKSUMS:
FBLazyVector: e97c19a5a442429d1988f182a1940fb08df514da
hermes-engine: e171ce5eb126654bf3fe00c8c6ac64370354a6c7
hermes-engine: 054cdf1294d0852c33cd980e7fcd94b4274ed8b3
IQKeyboardManager: c8665b3396bd0b79402b4c573eac345a31c7d485
libavif: 84bbb62fb232c3018d6f1bab79beea87e35de7b7
libdav1d: 23581a4d8ec811ff171ed5e2e05cd27bad64c39f
Expand Down Expand Up @@ -2962,7 +2962,7 @@ SPEC CHECKSUMS:
RNReanimated: e47df7f4580997c3a46b1e736ce3f26010985bb7
RNScreens: 6cb648bdad8fe9bee9259fe144df95b6d1d5b707
RNSVG: c69f7709226108f5eb89b5aa8833c17a36345468
RNWorklets: 7d24538032e023ed207e3b4d9b234695ddadd201
RNWorklets: 06ce05d69455cc14f5676c177050a39aa557d4d2
SDWebImage: e9fc87c1aab89a8ab1bbd74eba378c6f53be8abf
SDWebImageAVIFCoder: afe194a084e851f70228e4be35ef651df0fc5c57
SDWebImageSVGCoder: 15a300a97ec1c8ac958f009c02220ac0402e936c
Expand All @@ -2971,6 +2971,6 @@ SPEC CHECKSUMS:
SwiftAudioEx: f6aa653770f3a0d3851edaf8d834a30aee4a7646
Yoga: c0b3f2c7e8d3e327e450223a2414ca3fa296b9a2

PODFILE CHECKSUM: 7a33012cce520784bb5b691549f5ed2af273b7e3
PODFILE CHECKSUM: 336902a926a1c6b0b4e426a1eeb85e04f7bbf783

COCOAPODS: 1.16.2
Loading