-
Notifications
You must be signed in to change notification settings - Fork 65
[MOO-2075]: OPSqlite - Android 16kb pages compatibility #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/17.x.x
Are you sure you want to change the base?
Conversation
|
Hi @MxKevinBeqo, please add a link to the corresponding docs PR in the description. If documentation update is not required for this PR, you can add a comment with 'skip-docs-check' to skip this check. |
|
skip-docs-check |
| use_crsqlite = false | ||
| use_sqlcipher = false | ||
| -use_crsqlite = false | ||
| +use_crsqlite = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be use_sqlcipher = true and use_crsqlite = false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, thanks :)
| uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: 'temurin' | ||
| java-version: 17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are still on Java 17, can we revert this?
Description
Minor version update for OPSqlite, which includes 16kb pages alignment for vector search lib; update gradle. build yaml and patch file for this opsqlite version.
This PR contains
What should be covered while testing?
Testing the build and 16kb alignment using this template.