New: Add SVG export#111
Merged
Merged
Conversation
tonilastre
approved these changes
Jul 15, 2026
tonilastre
left a comment
tonilastre
left a comment
Contributor
There was a problem hiding this comment.
This is a great addition. I've added some nitpicking commments.
Comment on lines
+7
to
+15
| private readonly _filterRegion?: IRectangle; | ||
|
|
||
| constructor(filterRegion?: IRectangle) { | ||
| this._filterRegion = filterRegion; | ||
| } | ||
|
|
||
| get filterRegion(): IRectangle | undefined { | ||
| return this._filterRegion; | ||
| } |
Contributor
There was a problem hiding this comment.
Can all this be replaced with
constructor(public readonly filterRegion?: IRectangle) {}
Comment on lines
+131
to
+133
| const center = node.getCenter(); | ||
| const radius = node.getBorderedRadius(); | ||
| const pad = isShadowEnabled ? shadowReach(node.hasShadow(), node.getStyle()) : 0; |
| @@ -0,0 +1,37 @@ | |||
| export type SVGAttributes = Record<string, string | number | undefined | null>; | |||
| @@ -0,0 +1,36 @@ | |||
| import { IRectangle } from '../../common'; | |||
|
|
|||
| export class SVGDefs { | |||
Contributor
There was a problem hiding this comment.
Btw do we want to define ISVGDefs and this class can implement it so you can reference ISVGDefs in the rest of the code which uses the interface only. Right now, the class is being used in other types.
| } | ||
|
|
||
| getSVG(): string { | ||
| throw new Error('Method not implemented.'); |
Contributor
There was a problem hiding this comment.
Maybe some better error like SVG export is not supported on map view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds SVG export using
view.getSVG()on the default view, andgraphToSVG(graph)standalone. It serializes nodes and edges with their styling and node images (embedded as data URIs, so the output is self-contained).However,
OrbMapViewisn't supported as without the map tiles the SVG would just be the bare graph, sogetSVG()there throws instead of returning something half-useful.