Bump version to 1.7.0#85
Merged
Merged
Conversation
gitbuda
reviewed
Jul 13, 2026
imilinovic
previously approved these changes
Jul 13, 2026
imilinovic
dismissed
their stale review
July 13, 2026 13:07
Gareth's suggestion is nice, I approved before I've seen it
Ignition
approved these changes
Jul 14, 2026
Add a check that the shared library's ABI stays consistent with its version numbers, so an incompatible change cannot ship under an unchanged SOVERSION. The check compares the built library against an in-tree baseline of the last released ABI (captured with libabigail's abidw) using abidiff, classifying the result as an incompatible change, compatible additions, or no change. It then enforces the versioning policy: an incompatible change requires both SOVERSION and project VERSION to increase; compatible additions require a VERSION increase; no ABI change requires nothing. Because a minor version bump may carry an ABI break, SOVERSION rather than a semver major is the compatibility guard. The policy is a pure core, so the whole matrix is unit-tested with plain data without building anything; the shell around it gathers facts and renders. Classification reads no version data from CMakeLists.txt: SOVERSION comes from the built library's ELF SONAME and the version from its own mg_client_version(). An update subcommand refreshes the baseline, and optionally sets the CMake variables, on an intended ABI change or release. The check and the policy tests run as a new job on push and pull_request.
mattkjames7
commented
Jul 20, 2026
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added script to test and update the ABI.