Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/planning/perf-8757-journey-settle-0-7d2a5e91.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: none
---

### Changed

- surface-journey test: its browser session opens with playwright-cli's settle time at 0, so the twenty phase scripts, which wait for what they check themselves, no longer pay about 1 s each of post-script waiting.
9 changes: 8 additions & 1 deletion plugins/planning/surface/surface-checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,14 @@ if command -v playwright-cli >/dev/null 2>&1; then # prereq-ok: test-only, run b
pw run-code --filename "$(script_path "$1")" >"$2" 2>&1
echo "$((SECONDS - start))" >"$2.secs"
}
pw open >/dev/null 2>&1
# After each run-code, playwright-cli waits its settle time (500 ms by default), and again once the
# script's requests finish: about 1 s a call. The journey's twenty phase scripts wait for what they
# check themselves, so its own suite's session skips that wait. The setting is read only at open.
if [[ "$part" == journey ]]; then
PLAYWRIGHT_MCP_TIMEOUT_SETTLE=0 pw open >/dev/null 2>&1
else
pw open >/dev/null 2>&1
fi

group_ab() {
mkdir -p "$d"
Expand Down
Loading