Repository navigation
feat(work-items): add work-items:measure-delivery with the five DORA delivery metrics - #11930
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
Lane-Activity: pr-unblock/address-feedback Lane-Thread: PRRT_kwDOTCGFQM6yYWQH Lane-Thread: PRRT_kwDOTCGFQM6yYWQN Lane-Thread: PRRT_kwDOTCGFQM6yYWQU
…11904-measure-delivery
…section check-skills requires an eval for a new skill. The md-team-trend-names-no-person case asks for a per-author breakdown over a two-author history with one revert, and grades that the run uses delivery-metrics.sh, renders a Window row, names no person and writes nothing. The DORA pointer now names the page section that defines the five metrics, "Throughput and instability", in place of an unverified fragment id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The schema's top-level description keeps both readers: main's triage notes (triage_outside_prs, triage_stale_reporter_info_days) and this branch's /work-items:measure-delivery reader of delivery_deploy_signal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review (incremental, since 6444383)Scope: What changed: The jq pass that pulls Checks:
No security issues found. critical-findings: 0 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a780183d61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
claude-review reviewed Incremental review (6444383 → 5247d1e): no findings. Scope: the one changed hunk in I checked that this changes no output:
I did not run the script or its test file (no shell in this lane). That the tests pass is the author's claim and is unverified here. Closing issue #11874's criteria were checked in the earlier review of the unchanged files. This hunk does not affect any of them. |
Lane-Activity: pr-unblock/resolve-conflicts
…ly revert lines A merge whose member commit is titled `Revert "<subject>"` with no `This reverts commit` line was not seen: the subject match read only the merge commit's own subject. Merged commits' subjects now count when they name an earlier deployment. A `This reverts commit <sha>` line counted as rework even when the sha only ever existed on the landed branch, as in a squash body that lists a reverted work-in-progress commit. A named sha now counts only when the deployment's first parent reaches it (git merge-base --is-ancestor). The fixture adds a week with both cases. The eval scaffold drops the -q flag git revert does not accept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
README: keep main's youtrack onboard-adapter example and "adapters and seeds" wording, and this branch's measure-delivery usage line and row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reachability pass ran one merge-base per revert line in the branch's whole history; the report only uses pairs for deployments at or after --since, so filter the first-parent records to that window first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Post-merge mutation testingKilled 3, survived 5, timeout 0, no coverage 0, invalid 0, not run 0.
Surviving mutants
The run's summary has the full report. |
Closes #11874
Summary
Replaces #11904, a lanes App pull request whose
check-skillsfailure and one open review thread the fix lane could not clear, and which conflicted with main. This branch merges that head (00cfb3a084b0fd076cdd50af3783b87b002953ac) unchanged with--no-ff, merges main, and adds two fix commits on top.The original run's summary:
Known limits, documented in SKILL.md Gotchas: lead time reads short when a squash or rebase landing rewrites author dates, a rebase landing counts each of its commits as a deployment, and a hand-written undo with neither the
This reverts commitline nor aRevert "<subject>"subject is not counted.Fix
All of #11904's changes (the measure-delivery skill,
delivery-metrics.shand its test, thedelivery_deploy_signalschema key, the README, plugin.json, catalog and cheat-sheet rows, and the changelog fragment), plus:plugins/work-items/evals/md-team-trend-names-no-person/: a plugin eval case taggedmeasure-delivery. This was thecheck-skillsfailure (skill ships no evals/evals.json). The case asks for a per-author breakdown over a two-author history with one revert and grades that the run usesdelivery-metrics.sh, renders a Window row, names no person, and writes nothing.plugins/work-items/skills/measure-delivery/SKILL.md: the DORA pointer names the page section that defines the five metrics, "Throughput and instability" (review thread on feat(work-items): add work-items:measure-delivery with the five DORA delivery metrics #11904 asking for a section anchor). The rendered page exposes no fragment id that could be confirmed, so the pointer names the heading instead of guessing one.work-items.schema.json's top-level description keeps main's triage notes and this branch's measure-delivery reader.Verification
bash plugins/skill-quality/scripts/check-skill.sh --require-evals plugins/work-items/skills: 11 passed, 0 failed (evals: a plugin suite case tags measure-delivery). Before the fix:CHECK-SKILL measure-delivery: FAILin https://github.com/melodic-software/claude-code-plugins/actions/runs/41287542624/job/124818349360.python3 -I plugins/evals/skills/validate/scripts/validate-cases.py plugins/work-items/evals: no FAIL; every new grader's samples sort as expected.bash plugins/work-items/skills/measure-delivery/scripts/delivery-metrics.test.sh: all passed, after the main merge.check-affectedpassed.Related
Related: replaces #11904
🤖 Generated with Claude Code