Repository navigation
fix(user-interface): trigger design on single visual-value questions - #11895
Conversation
design's description now claims deciding one corner radius or shadow, even when every number is given, so a nested-radius question routes to it instead of being answered without the skill. write-css adds 'fix this layout in the stylesheet' to its triggers. design.json adds shape probes. Refs: #11423 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #11895No security issues found. I read every hunk in all 4 changed files:
What I checked:
Spend: none beyond normal trigger behaviour. The changed descriptions may make the design skill auto-load slightly more often, which only uses subscription usage. critical-findings: 0 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67983857df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
claude-review reviewed Code review: PR #11895, no findingsI read every hunk of all 4 changed files:
None of them matches a trusted-path glob. What changed. The PR changes two skill descriptions. In design, "to decide how something should look" becomes "…down to one corner radius or shadow, even with every number given". write-css gains the trigger 'fix this layout in the stylesheet'. The PR also adds three shape probes to Checks
Closing issue #11423. The reopen comment lists three open items:
Embedded text. The PR context contains no instructions aimed at the review lane. Spend. None. The change only alters model-invocation wording and probe data. |
|
Arm request (Emil lane, for the hub): #11895 is ready to arm once ci-status re-runs green on head 6798385. do-not-merge is removed, the Codex P1 thread is answered with round-5 VALID probe runs and resolved (0 open threads), both review lanes posted for this head, and the body cites round 5. Owner decision (2026-11-01, in session): the nested-radius condition is judged on runs with no error or denial, counting unfired runs as data, because the gate's skill-fired check rejects base not firing on that case, which is the behavior this change fixes. |
Closes #11423
Summary
The last three items on #11423.
/user-interface:designnow auto-invokes on a question about a single visual value, such as a nested element's corner radius or a layer's shadow, even when the question gives every number. Before this change the model answered those questions itself and loaded no skill, which is whyshape-and-depth-nested-radiusfired no skill on base or head. The probe sets are re-measured on current main with the four probes reworded after #11765./user-interface:write-cssgets one added trigger, chosen by a pass rule written before any result was read.Fix
plugins/user-interface/skills/design/SKILL.md: "to decide how something should look" now reads "to decide how something should look, down to one corner radius or shadow, even with every number given".plugins/user-interface/skills/write-css/SKILL.md: adds the quoted trigger 'fix this layout in the stylesheet'.plugins/user-interface/probes/design.json: adds three shape probes (pos-train-shape-01,pos-train-shape-02,pos-validation-shape-01); one of them gives every number..changes/user-interface/fix-11423-shape-and-css-triggers-7d3a91c2.md.Verification
Round 4 chose these two descriptions (design A3 and write-css B2) under a pass rule written before any result was read, but
run-validity.pyjudged every round-4 probe side INVALID, so its numbers count for nothing. Round 5 re-measured the same two descriptions on runs the gate judges VALID, under a decision rule written before any round-5 run started.Round 5 setup.
claude plugin eval, 3 runs per case, opus judge,--ablation none, Claude Code 2.1.316, both sides concurrently. Base isplugins/user-interfaceat main c3a4498. Head is base with only the twodescription:lines replaced by this PR's. Probe cases: main'sdesign.jsonandwrite-css.json, the three shape probes above, and a held-out set of 6 design and 6 write-css probes (written by a fresh agent from neutral purpose statements, not committed), emitted bymeasure-invocation.sh emit-plugin-eval --runs 3and run with--disallow-tools Read Glob Grep Agent.Gate.
run-validity.py --runs 3: base probes VALID, head probes VALID (297 of 297 traces read, no errored runs, no permission denials).noise-report.py <head> --baseline <base> --margin 0.05: paired change +0.06 over 99 cases (95% interval +0.02 to +0.10), non-inferior.shape-and-depth-nested-radius(the case the design change targets; 3 runs per side, no errored runs, no denials):border-subtracted) passedThe gate marks the named-four result files INVALID on both sides for reasons outside this measurement: its skill-fired check counts base not firing on this case, which is the behavior the change fixes, as an invalid run; base also had one denied plugin-root Glob in
states-projects-list, and head one unfiredaccessibility-mobile-nav-drawerrun. The owner decided to judge this case on its runs with no error or denial, counting unfired runs as data.Outcome against the round-5 rule.
measure-invocation.sh validatepasses on the four probe files.check-skill.shpasses design and write-css.Related
claude plugin eval)🤖 Generated with Claude Code