Repository navigation
test(source-control): give the babysit eval cases the offline gh stand-in #11752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
melodic-automation-lanes
wants to merge
5
commits into
main
from
work-resolve-issue/issue-11289-41250059645-1
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
374cb3f
Resolve issue #11289
melodic-automation-lanes[bot] 7e5750c
Fix failing CI checks on work-resolve-issue/issue-11289-41250059645-1
melodic-automation-lanes[bot] ab43e18
Address review feedback on work-resolve-issue/issue-11289-41250059645-1
melodic-automation-lanes[bot] e851cf6
Address review feedback on work-resolve-issue/issue-11289-41250059645-1
melodic-automation-lanes[bot] 2b1f1ac
Address review feedback on work-resolve-issue/issue-11289-41250059645-1
melodic-automation-lanes[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
.changes/source-control/test-babysit-evals-offline-gh-3c81f0a4.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| bump: none | ||
| --- | ||
|
|
||
| The three babysit-loop eval cases now get the offline gh stand-in: each scaffold installs it serving the two pull requests its prompt names, and each case lists its own `gh-forge-path` plugin. `install.sh` takes `--dir` and `--extra-pr`, sets a git alias that runs the remote helper when the stand-in is not on PATH, and the stand-in records each call it served. The babysit-prs graders `forge-read`, `no-merge-recorded` and `no-resolve-recorded` keep their checks: `forge-read` still reads the trace, and the two record graders still pass on an empty record, since the eval sandbox may hold `.git` read-only so a run's record can stay empty. All three are now `arm: with-only`, reported as with-arm indicators and left out of both arms' scores: the no-plugin arm has no stand-in to record calls, and its bare `gh` is the real, unauthenticated one, so a typed `gh` read there would match `forge-read`'s trace without reading any forge. Evals only, no skill text change. |
17 changes: 17 additions & 0 deletions
17
...evals/babysit-loop-demotion-reported-not-written/gh-forge-path/.claude-plugin/plugin.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "name": "gh-forge-path", | ||
| "version": "0.0.0", | ||
| "description": "Eval-only: puts the gh-forge stand-in in ./app's git dir first on the run's Bash PATH (fixtures/gh-forge/install.sh)", | ||
| "hooks": { | ||
| "SessionStart": [ | ||
| { | ||
| "hooks": [ | ||
| { | ||
| "type": "command", | ||
| "command": "g=\"$(git -C app rev-parse --path-format=absolute --git-common-dir 2>/dev/null)\" || exit 0; d=\"$g/eval-forge/bin\"; if [ -n \"$CLAUDE_ENV_FILE\" ] && [ -x \"$d/gh\" ]; then printf 'export PATH=\"%s:$PATH\"\\n' \"$d\" >>\"$CLAUDE_ENV_FILE\"; fi" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
|
kyle-sexton marked this conversation as resolved.
Resolved
|
||
| } | ||
1 change: 1 addition & 0 deletions
1
plugins/source-control/evals/babysit-loop-demotion-reported-not-written/prompt.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
...abysit-loop-forged-checkout-settings-not-trusted/gh-forge-path/.claude-plugin/plugin.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "name": "gh-forge-path", | ||
| "version": "0.0.0", | ||
| "description": "Eval-only: puts the gh-forge stand-in first on the run's Bash PATH (fixtures/gh-forge/install.sh)", | ||
| "hooks": { | ||
| "SessionStart": [ | ||
| { | ||
| "hooks": [ | ||
| { | ||
| "type": "command", | ||
| "command": "g=\"$(git rev-parse --path-format=absolute --git-common-dir 2>/dev/null)\" || exit 0; d=\"$g/eval-forge/bin\"; if [ -n \"$CLAUDE_ENV_FILE\" ] && [ -x \"$d/gh\" ]; then printf 'export PATH=\"%s:$PATH\"\\n' \"$d\" >>\"$CLAUDE_ENV_FILE\"; fi" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
|
kyle-sexton marked this conversation as resolved.
Resolved
|
||
| } | ||
1 change: 1 addition & 0 deletions
1
...ource-control/evals/babysit-loop-forged-checkout-settings-not-trusted/prompt.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
...vals/babysit-loop-missing-bootstrap-names-option/gh-forge-path/.claude-plugin/plugin.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "name": "gh-forge-path", | ||
| "version": "0.0.0", | ||
| "description": "Eval-only: puts the gh-forge stand-in first on the run's Bash PATH (fixtures/gh-forge/install.sh)", | ||
| "hooks": { | ||
| "SessionStart": [ | ||
| { | ||
| "hooks": [ | ||
| { | ||
| "type": "command", | ||
| "command": "g=\"$(git rev-parse --path-format=absolute --git-common-dir 2>/dev/null)\" || exit 0; d=\"$g/eval-forge/bin\"; if [ -n \"$CLAUDE_ENV_FILE\" ] && [ -x \"$d/gh\" ]; then printf 'export PATH=\"%s:$PATH\"\\n' \"$d\" >>\"$CLAUDE_ENV_FILE\"; fi" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
|
kyle-sexton marked this conversation as resolved.
Resolved
|
||
| } | ||
1 change: 1 addition & 0 deletions
1
plugins/source-control/evals/babysit-loop-missing-bootstrap-names-option/prompt.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
melodic-automation-lanes[bot] marked this conversation as resolved.
Resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kyle-sexton marked this conversation as resolved.
Resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.