Skip to content

docs: point standards links at the renamed standards/ folder - #11377

Merged
kyle-sexton merged 1 commit into
mainfrom
docs/standards-folder-rename
Oct 31, 2026
Merged

docs: point standards links at the renamed standards/ folder#11377
kyle-sexton merged 1 commit into
mainfrom
docs/standards-folder-rename

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Oct 30, 2026

Copy link
Copy Markdown
Member

Refs: melodic-software/standards#790

Summary

melodic-software/standards renames its conventions/ folder to standards/
in melodic-software/standards#930.
GitHub does not redirect blob URLs after a folder rename, so links and path
citations to the old folder stop resolving once that PR merges.

Fix

Point 20 lines in 10 files at standards/... instead of conventions/...: ADRs 0003 and 0023, five docs/contracts/*/README.md files, docs/migration-playbook.md, docs/plugin-philosophy.md and the attribution audit rubric. A none changelog fragment covers the attribution plugin file. The historical entry in docs/contracts/upstream-drift/CHANGELOG.md is left as written.

Merge this after melodic-software/standards#930 merges; before that, the new
paths do not exist yet.

Verification

  • Every edited path exists on the standards rename branch (standards/engineering/*.md).
  • The pre-push check-affected hook passed (10 checks passed, none failed).

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01VcupojYKhHyDni9LuAXBuX

@kyle-sexton @claude
docs: point standards links at the renamed standards/ folder
6b9ba97 
melodic-software/standards renames its conventions/ folder to
standards/, and GitHub does not redirect blob URLs after a rename.
Update every reference here to the new path.

Refs: melodic-software/standards#790

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VcupojYKhHyDni9LuAXBuX
This was referenced Oct 30, 2026
Merged
Merged
kyle-sexton added a commit to melodic-software/standards that referenced this pull request Oct 31, 2026
@kyle-sexton @claude
refactor: rename conventions/ to standards/ (#930)
7482e79 
Closes #790

## Summary

Rename the top-level `conventions/` folder to `standards/`, so the
folder
name matches the repository name and the `docs/standards/` path every
consumer already syncs into. The owner approved the rename on
2026-10-15.

## Fix

Two commits, so history follows the move:

1. `refactor: move conventions/ to standards/`: `git mv` only, 56 files,
   all 100% similarity renames.
2. `refactor: point every reference at standards/`: 88 lines in 24 files
(87 path references plus the `standards/README.md` heading). Relative
links, absolute `blob/main/conventions/...` URLs inside the
   moved files, prose paths in `README.md`, `AGENTS.md`, `REVIEW.md`,
   `distribution/`, `docs/` and component READMEs, and the eight
engineering-standards source keys in `distribution/sync-manifest.yml`.
   After merging main, `.github/trust-path-hold.json` is gone (#931), so
   its glob edit dropped out with it.

Left unchanged on purpose: consumer-side `docs/conventions/...` paths
(for
example the commit-convention destination), links into
`claude-code-plugins/docs/conventions/`, the
`github-actions-conventions`
component, and every use of "conventions" as an ordinary word.

No workflow, lint config or test in this repository names the old
folder,
so none needed an edit (`git grep` over every tracked file).

## Verification

- `bash distribution/sync-manifest.sh validate`: `Manifest valid: 47
  components, 14 targets`, before and after.
- `bash distribution/sync-manifest.sh plan`, before (origin/main) and
after:
  the set of (target, mode, destination path) triples is identical, 374
  rows. The only plan lines that differ are the eight source paths
  (`conventions/engineering/*.md` to `standards/engineering/*.md`), once
  for each of the 10 targets that adopt `engineering-standards`.
- Destination bytes: the next sync changes content only, at the same
paths. Synced files whose text named the old folder now name the new
one:
  `REVIEW.md`, `docs/standards/README.md`, and six of the eight
  `docs/standards/*.md` files (their `blob/main/...` URLs).
- `git grep -nP '(?<![\w-])(?<!docs/)conventions/'` returns nothing.
- Every `test:*` and `lint:*` script in `package.json` passes (after
`npm ci`
  in the root, `distribution/` and each component with a lockfile).
- `harness/shell/run-tests.sh` over all 41 `*.test.sh` files: 39 pass.
`components/go-analysis/go-analysis.test.sh` and
`components/ruff/ruff.test.sh`
fail identically on an untouched origin/main checkout (local
golangci-lint
2.13.2 against a pinned 2.12.2 and a Go 1.27 export-data mismatch; local
  ruff 0.17.0), so they are local toolchain drift, not this change.

## Related

Other repositories that cite standards' `conventions/...` paths. GitHub
does
not redirect blob URLs after a rename, so each gets a draft PR that
lands
after this one merges:

-
[melodic-software/claude-code-plugins#11377](melodic-software/claude-code-plugins#11377):
20 lines in 10 files (ADRs 0003 and 0023, five
`docs/contracts/*/README.md`,
`docs/migration-playbook.md`, `docs/plugin-philosophy.md`, the
attribution
  audit rubric).
-
[melodic-software/github-iac#807](melodic-software/github-iac#807):
  `README.md` and `LabelsGrammarTests.cs` (3 lines).
-
[melodic-software/provisioning#886](melodic-software/provisioning#886):
  ADR 0003 (2 blob URLs) and two topic plans (4 lines).
-
[melodic-software/.github#224](melodic-software/.github#224):
  `CONTRIBUTING.md` (1 blob URL).
-
[melodic-software/medley#2257](melodic-software/medley#2257):
  `docs/conventions/progressive-disclosure.md` (1 blob URL).

Not edited: the historical entry in claude-code-plugins
`docs/contracts/upstream-drift/CHANGELOG.md`, and dated research notes
under
`.work/` in medley and knowledge-corpus. azure-iac has no reference.

Synced copies update through the normal sync PRs after merge and need no
hand edit: `REVIEW.md` in 12 targets, `docs/standards/*` in 10.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01VcupojYKhHyDni9LuAXBuX

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review October 31, 2026 05:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T05:38:34.559550Z 6b9ba97 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 6b9ba975bb5a184a33296cb067c7ebc55c4b2429: 0 finding(s), 0 as inline comments.

No security issues found.

I read the whole diff (11 files) and the PR context. The change rewrites conventions/engineering/... to standards/engineering/... in 20 prose citations. It also adds one bump: none changelog fragment. The edited files are two ADRs, five docs/contracts/*/README.md files, docs/migration-playbook.md, docs/plugin-philosophy.md and the attribution audit rubric at plugins/attribution/skills/audit/reference/rubric.md.

  • Trusted paths: none of the changed files match a trusted-path glob. The docs/contracts files touched are not under untrusted-content or the instruction-exception register.
  • Instruction surface: no standing instruction is deleted, narrowed or softened. Each edit changes only a cited path inside prose, and the rule each citation supports reads the same.
  • Manifests: there is no plugin.json or marketplace.json change.
  • Trust controls: the diff touches no workflow, action, script, token scope, kill switch or merge hold.
  • PR context: the description holds no embedded instructions aimed at the review lane.

critical-findings: 0

Spend: none. The diff changes no run, schedule or billing setting.

@github-actions

github-actions Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

claude-review reviewed 6b9ba975bb5a184a33296cb067c7ebc55c4b2429: 0 finding(s), 0 as inline comments.

No findings. I read the full diff (.claude-lane/pr.diff) and the PR context.

What changed: 20 path citations in 10 files move from melodic-software/standards conventions/engineering/... to standards/engineering/..., plus a bump: none changelog fragment for the attribution plugin. All of them are prose or reference-doc edits. I found no behavior change, no manifest change and no userConfig change, so no manifest <field> lines apply. No trusted-path glob matched a changed file.

Checks I ran:

  • Every edit is a mechanical conventions/ to standards/ swap, and each edited line reads correctly in context.
  • I grepped the repo for remaining conventions/engineering/ references. Outside the diff there are two groups:
  • The .changes/attribution/ fragment uses the same frontmatter shape as the existing .changes/planning/ fragment. bump: none fits a plugin file whose only change is a reference-doc path.

Not independently verified: the PR says every edited path exists on the standards rename branch. That branch isn't available in this run, so I couldn't check it. The PR also says the merge order is after melodic-software/standards#930. Until that merges, the new paths don't resolve.

Closing issues: the PR context has no closing-issue section, only Refs: melodic-software/standards#790. There were no acceptance criteria to check.

Cost: no billing or paid-resource change.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit e792b63 Oct 31, 2026
77 of 78 checks passed
@kyle-sexton
kyle-sexton deleted the docs/standards-folder-rename branch October 31, 2026 05:52
@kyle-sexton kyle-sexton mentioned this pull request Nov 2, 2026
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kyle-sexton