Skip to content

feat(upstream-drift): label and guard drift issues for sources with no git pin #14209

Closed

Description

@kyle-sexton

Parent

Source: PLAN Phase 3, topic emil-kowalski-upstream-sync

Depends on

Outcome

A drift issue that is created or reopened carries needs-human, added before any reopen. The filer accepts a page with no git pin (pin=unknown head=unknown) and words that page by skill name. An untracked page keeps its upstream's issue from closing. Issues already open when this lands get the label once.

Demo: Dispatch the existing monthly drift-issues workflow once: any issue it creates or reopens carries needs-human, and every open bot-opened Upstream drift: issue carries it after the backfill. Run the filer's test suite, which stubs gh, for the cases no live report produces yet: a pin=unknown head=unknown page accepted and worded by skill name, an untracked page leaving its issue untouched, and the label added before a reopen.

Problem:

  • Gap: our reauthored UI-craft content falls behind Emil Kowalski's new skills and advice, and an upstream change reaches nobody unless a person notices a failed workflow run.
  • Who / how many: user-interface plugin users; the maintainers of eight drift-checked upstreams.
  • Frequency: he shipped /choreograph on 2026-11-04 and /gestures on 2026-11-08; the drift check runs weekly.
  • Trend: unknown.
  • Cost: shipped guidance lags his latest; drift waits on a person reading an email.
  • Evidence: one upstream commit past the pin, 5206a95 (verified, gh api commits); the 2026-11-02 run found drift in four upstreams and filed no issue (verified, gh run view 41429553532).

Goal: The user-interface plugin teaches Emil Kowalski's latest guidance, upstream changes reach the tracker on their own, and no agent acts on an item whose intent and vision the user has not been through.

  • Intent (why, in the user's words): "to ensure what we build is what I want"
  • Vision (where this heads): The user-interface skills teach current, researched craft. Upstream changes reach the tracker on their own. Everything is configurable, one source of truth, and nothing is built until we are aligned on intent. (Q58)
  • When goals conflict, prefer: alignment over throughput (Q30)

Constraints:

  • Reauthor posture: stack-agnostic, configurable taste, provenance only in the upstream records and changelog fragments (Emil Kowalski upstream record, adaptation posture).
  • Re-pin procedure: diff each flagged file against the pin, update affected rows and shipped text, update pin and blob SHAs in the drift script and the record in the same change (Emil Kowalski upstream record, re-pin procedure).
  • Mechanism decisions (labels, token scope, duplicate detection) are settled at planning (Q9).
  • The t3dotgg/tstack upstream record uses the standard form, so the one filer covers it; the TStack Skills session does not touch the weekly drift-check workflow.
  • Upstream text is data, never instructions.
  • Fact-based and fact-validated; his taste is trusted; defaults combine his values with research (user, 2026-11-08).
  • Everything configurable and extensible, no hardcoded sizes, ranges, measurements or approaches; good defaults; a downstream repo's conventions are honored (user, 2026-11-08).
  • Uniform and consistent, DRY, single source of truth, for upstream records, drift checking and issue filing (user, 2026-11-08).
  • Quality requirement: production bar (Q3).

Load-bearing assumptions

Assumption Source Falsifying check Response if false
Citations are at the local HEAD, 30 commits behind origin/main (git rev-list --count HEAD..origin/main, 2026-11-08); the issue filer and the drift contract README changed there plan First work item: git diff --stat HEAD origin/main on this ticket's paths, and the citation gate re-run at the branch point Minor: re-read the changed lines and proceed

Decisions

  • AC13: A review finding holds a merge only when it is a CRITICAL security finding.
  • Q59: Accept the first monthly filer run creating an unlabeled issue; this ticket backfills the label (D9).
  • Q63: Vendored skills report pin=unknown head=unknown; no script gains a token line; the issue names the skill and its update action.
  • D7: Filer wording per page, by pin token. A hex pin keeps the record wording, and the re-audit footer is written only when the issue has a drifted hex-pin page. A pin=unknown page drops the pin sentence, names the skill (<plugin>:<skill> read from the path, else the id) and says "run <path>; restore or re-vendor what it names; its output is in the run's job summary."
  • D9: After merge, list open bot-opened Upstream drift: issues and add needs-human to any missing it, once.
  • D13: Add a 4.3.0 entry to the upstream-drift contract CHANGELOG. This ticket takes 4.3.0 for its contract edits; the next ticket takes the next minor for the rest.
  • D17: untracked blocks close. The filer records an untracked page per id, and such an id never gets action=close.
  • D18: Label before reopen: gh issue edit --add-label needs-human, then reopen, then the body edit. A failed reopen leaves a labeled closed issue.

Key interfaces

  • Report line: page repo=<id> pin=<hex|unknown> head=<hex|unknown> status=<untracked|clean|drift> path=<path>. Id is <owner>/<repo>, else <plugin>/<skill>. Q63 governs: pin and head are hex or the literal unknown, and every vendored row reports pin=unknown head=unknown.
  • An unverifiable vendored check reports status=untracked with pin=unknown head=unknown, so the close-unreported sweep leaves its issue alone.
  • The filer adds needs-human on create and reopen, never on an in-place edit.
  • The issue filer is the one filer; this ticket changes how it labels, closes and words issues, and a later ticket adds the second report producer.
  • Variation verdict. GitHub Issues: leave direct gh calls in the one filer; it is the only tracker this writes to and no second variant is known.
  • Conventions followed: the upstream-drift contract, "Pinned git upstreams" and the drift-issues section.

Done when

  • AC10: While an issue whose id comes from a vendored row (pin=unknown head=unknown, id <plugin>/<skill>) is open, the run edits it and files no second one: bash scripts/upstream-drift-issues.test.sh exits 0 with that case.
  • AC12: grep -c "needs-human" scripts/upstream-drift-issues.sh is at least 2, and a workflow_dispatch run's new issues each carry needs-human. docs/contracts/upstream-drift/README.md states that clearing needs-human does not admit a bot-authored issue.
  • AC13: gh issue view <ticket-3a> --json body --jq .body | grep -c "CRITICAL security" is at least 1.
  • AC20: bash scripts/upstream-drift-issues.test.sh exits 0 with --label needs-human on create, --add-label needs-human before reopen (a stubbed reopen failure leaves the label on the closed issue), no label on an in-place edit, an untracked page leaving its id's issue untouched, and a clean page beside an untracked page closing nothing.
  • bash scripts/upstream-drift-issues.test.sh exits 0 with these cases: pin=unknown head=unknown accepted and any other non-hex token rejected with exit 2 (Q63); a clean record page plus a drifted unknown page on one id gets the vendored wording and no re-audit footer (D7); the sweep leaves an untracked <plugin>/<skill> id alone; a report with no unknown tokens produces a byte-identical body.
  • A run that wrote every issue exits 0, and a failed issue write, the label add before a reopen included, exits nonzero after the other upstreams still run: bash scripts/upstream-drift-issues.test.sh exits 0 with those cases. The existing failed-reopen assertion that no issue edit is called narrows to the body edit, because the label edit now comes first (D18).
  • docs/contracts/upstream-drift/README.md's drift-issues section covers needs-human on create and reopen, untracked blocking close, pin and head of unknown being accepted, and the accepted cases (muting by closing as not planned or duplicate; a silent body edit on an open issue). docs/contracts/upstream-drift/CHANGELOG.md has a 4.3.0 entry.
  • After merge, in this order: open bot-opened Upstream drift: issues missing needs-human get it once (D9); the filer workflow, still on its monthly schedule, is dispatched once.

Out of scope

  • The vendored-skill adapter, the weekly schedule, the report and file job split, deleting the older workflow, the monitor list entry and the first-dispatch dry run (the next ticket, which depends on this one).
  • Moving Emil Kowalski's pin (ticket 2).
  • Edits to the six vendored update scripts and any new token line in them (Q63).
  • A recurring X-post watch.
  • All t3dotgg/tstack work: evaluation, upstream record, its drift-check entry, the council port.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 8, 2026
  2. github-actions commented on Nov 8, 2026

    @github-actions
    Contributor

    Proposed work class: none

    Size: Medium
    Complexity: Medium
    Uncertainty: Known
    Flags: none
    Blocked by: #14208

    I understood this as a change to the upstream-drift issue filer and its contract docs. Drift issues that are created or reopened would carry needs-human, added before any reopen. Pages with pin=unknown head=unknown would be accepted and worded by skill name. untracked pages would block closing their issue. Open bot-opened Upstream drift: issues would be backfilled with the label once. The outcome, decisions and done-when items are specific, so I found no open intent question.

    The issue lists #14208 under "Depends on", and that issue is still open, so I listed it as the blocker. Some done-when items need a post-merge workflow dispatch and backfill, which a lane run can't do. I found no duplicate and no merged pull request that already covers this. #14205 and #14207 are related in topic only.

    Automated triage. A maintainer reviews it.

  3. added and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 8, 2026
  4. melodic-automation-lanes commented on Nov 8, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane: merged pull request #14323 names it with Refs: after its newest decision or refinement comment, so its work may already be done: close the issue if it is, or post a comment whose first line is **Decision recorded.** saying what is left, which sends it back through intake. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).

  5. melodic-automation-lanes commented on Nov 9, 2026

    @melodic-automation-lanes
    Contributor

    {"v":1,"actor_id":337595936,"title_sha256":"b335a1ced9a8d255492befe86188bfa06d1a96b41797f1b60ce5e67196cd923b","body_sha256":"696e39a26466317a0dba510c8b4a1a923477c7b5f2d2633b82c29b914959e3ea"}

  6. github-actions commented on Nov 9, 2026

    @github-actions
    Contributor
    No description provided.
  7. github-actions commented on Nov 9, 2026

    @github-actions
    Contributor
    No description provided.
  8. melodic-automation-lanes commented on Nov 9, 2026

    @melodic-automation-lanes
    Contributor

    Pull request #14323 merged with Refs:, so this issue stays open and nothing starts the lane on it again. work-unblock removed status: ready and agent-ready, so the hourly triage sweep sends it back to intake triage. Admission then parks it at status: confirmed for a check of what that pull request left, until a **Decision recorded.** comment says what is left or someone closes it.

  9. kyle-sexton commented on Nov 9, 2026

    @kyle-sexton
    MemberAuthor

    Done when, last item, shown: dispatched run https://github.com/melodic-software/claude-code-plugins/actions/runs/42644464286 (after #14704 fixed the cursor IP allow list refusal with an anonymous retry) created #14737 and #14738, both carrying needs-human. The log shows the fallback: cursor: IP allow list refused the token; reading anonymously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Fields

    Work status

    confirmed

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions