Skip to content

refactor(skill-quality): give skill-quality:check a distinct leaf name #12498

Closed as not planned

Description

@kyle-sexton

Refs #12489

Blocked by #12488

Outcome

skill-quality:check, the skill-authoring QA gate, gets a distinct leaf name and a first description clause that sets it apart. The new name is chosen with /naming:name-it-better and swept with /docs-hygiene:rename-references. What the skill does is unchanged. This is one of three renames split from #12489. Estimated size: 106,386 bytes of rename (53,193 tracked bytes, counted twice under --no-renames) plus 84 reference lines in 41 files, about 175 KB; the pull request states the measured size.

Done when

The done-when lines below are copied from #12489 as written, except the first, which is narrowed to this part's skill. The Scope line names the target this part covers.

  • git grep -c -E '/skill-quality:check([^a-z0-9-]|$)' -- . ':!**/CHANGELOG.md' ':!.changes/**' prints nothing (refactor(plugins): give the three non-prerequisite check skills distinct names so no check leaf remains #12489's three-name grep, narrowed to this part's skill; the parent's item 2 checks all three).
  • Each renamed skill's description starts with a clause no other installed skill's description starts with.
  • Eval evidence of no loss of triggering, per plugins/playbooks/skills/skill-authoring/reference/skill-criteria.md: a description change re-measures triggering on the probes, and each skill's existing evals run with /evals:plugin-eval --baseline <before.json> --margin <m> and show non-inferiority.
  • scripts/validate-plugins.sh passes, and so does bash scripts/sync-shared-copies.sh --check-bump origin/main.
  • A merge probe is posted per D82/Q186 for each sub-slice.

Scope: skill-quality:check

Notes

Drafted by the issue-triage session. The eval is Claude subscription or promotional-credit usage, not cost (docs/contracts/loop-lane/README.md:349), so a host run makes it. Use non-Fable models for the agent and judge runs.

Related

Activity

  1. added theissue type on Nov 2, 2026
  2. added
    priority: mediumReal value, no hard deadline; normal backlog flow.
    work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.
    host-runNeeds an agent run or builder session on a host; not a person or the issue lane.
    on Nov 2, 2026
  3. github-actions commented on Nov 2, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: structural
    Basis: automated intake triage; the lanes App applied this class.

    Size: Medium
    Complexity: Medium
    Uncertainty: Known
    Flags: none
    Blocked by: #12488

    Understood: rename skill-quality:check to a distinct leaf name, chosen with /naming:name-it-better. Give its description a unique first clause, sweep references across about 41 files, and leave the skill's behavior unchanged. This is one of three renames split from #12489.

    The eval-evidence item needs a host run. An unattended lane can't do that item, so it doesn't hold the rest of the issue. The other done-when items can be checked in the lane.

    Cost: none flagged. Eval runs draw on prepaid or subscription credit.

    I found no duplicates. #12497 and #12499 are the sibling renames for other skills.

    Automated triage, applied by the lanes App.

  4. added
    status: needs-decisionAwaiting a human or maintainer judgment call.
    and removed
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    on Nov 2, 2026
  5. melodic-automation-lanes commented on Nov 2, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane: its done-when asks for what an unattended lane run cannot perform: item 3 (a model eval run: "Eval evidence of no loss of triggering, per plugins/playbooks/skills/skill-au..."); recommended split: keep the other items here as the admissible issue and move these to a child issue for the host queue (host-run); it carries host-run. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).

  6. melodic-automation-lanes commented on Nov 2, 2026

    @melodic-automation-lanes
    Contributor

    The latest triage verdict holds nothing: admission moved the issue to status: confirmed; its comment says why.

  7. added
    status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.
    and removed
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    on Nov 3, 2026
  8. kyle-sexton commented on Nov 3, 2026

    @kyle-sexton
    MemberAuthor

    Closed as not planned on the owner's decision recorded at #12489 (comment): the check leaf stays, since the only reason for the rename was the Cursor /check collision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    host-runNeeds an agent run or builder session on a host; not a person or the issue lane.priority: mediumReal value, no hard deadline; normal backlog flow.status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.

    Type

    Fields

    Work status

    confirmed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions