Skip to content

rulesets: remove the duplicate pull_request rule in org ruleset 17988999 #12438

Open

Description

@kyle-sexton

Refs: #12284

Owner: Automation Lanes. This is a settings change, not code. Automation Lanes applies it only after checking that it removes nothing but a duplicate and loosens nothing.

Summary

On main, two organization rulesets each carry a pull_request rule (GET repos/melodic-software/claude-code-plugins/rules/branches/main, read 2026-11-02):

Ruleset dismiss_stale_reviews_on_push Other parameters
17988999 false squash only, 0 approvals, thread resolution required, extra approval for unattributed changes
24475076 true the same

GitHub applies the stricter value of each parameter when several rules apply, so the effective rule is ruleset 24475076's. Ruleset 17988999's pull_request rule duplicates it. This affects every repository the two organization rulesets target, not only this one. Source: audit comment, gate #16.

The measured cost is none. This slice removes a second place where the same setting must be kept in step.

Done when

  • Both rulesets' targets (repositories and branches) are listed, and every target of 17988999's pull_request rule is also covered by 24475076's with equal or stricter values. Otherwise the stricter values are carried into the kept rule first.
  • The duplicate pull_request rule is removed through the repository that manages organization rulesets (github-iac), not by hand.
  • rules/branches/main read after the change shows one pull_request rule, with values equal to or stricter than today's on every parameter.

Activity

  1. github-actions commented on Nov 2, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Small
    Complexity: Low
    Uncertainty: Knowable
    Flags: none
    Blocked by: none

    Understood: two organization rulesets (17988999 and 24475076) both carry a pull_request rule on main. The effective rule is the stricter one, from 24475076. You want the duplicate in 17988999 removed through github-iac. First, you want to confirm that every target of 17988999 is also covered by 24475076 with equal or stricter values. After the change, rules/branches/main should show one pull_request rule that is no looser than today's.

    The scope and done-when are exact, so nothing is missing. I found no open duplicate.

    Automated triage, applied by the lanes App.

  2. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.
    on Nov 2, 2026
  3. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    on Nov 2, 2026
  4. github-actions commented on Nov 2, 2026

    @github-actions
    Contributor
    No description provided.
  5. github-actions commented on Nov 2, 2026

    @github-actions
    Contributor
    No description provided.
  6. added
    attendedNeeds the owner present: DNS, keys or secrets, elevation, non-IaC provisioning.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 2, 2026
  7. melodic-automation-lanes commented on Nov 2, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue lane stopped on this issue (manual-external): the run reports the work needs a manual step on external state, one of pr-pipeline.yaml's attended classes, which needs the owner present.
    It added attended and removed agent-ready: the step needs the owner present, and it waits on no decision from a person.

    In the run's words:

    manual-external: the change is to live organization rulesets 17988999 and 24475076 (external GitHub state). Per the issue, it is applied through the separate github-iac repository by the Automation Lanes owner, who first checks the rulesets' live targets and then reads rules/branches/main after the change. This lane can change only the claude-code-plugins checkout, cannot read or write the github-iac repository, and has no GitHub API access for reading the rulesets' targets or the branch rules. No done-when item can be met or checked from here.

    What the run says it did not do:

    • Listing both rulesets' targets and comparing 17988999's pull_request parameters against 24475076's: needs the live GitHub org rulesets API, which this lane cannot call
    • Removing the pull_request rule from ruleset 17988999 in github-iac: a separate repository outside this lane's checkout, owned by Automation Lanes
    • Reading rules/branches/main after the change to confirm one pull_request rule with equal or stricter values: needs live API access after the github-iac change is applied
    • Tidy, review and verify steps skipped: no change was made

    Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/41494965421

    Once the step is done, a listed human removes attended and adds agent-ready again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    attendedNeeds the owner present: DNS, keys or secrets, elevation, non-IaC provisioning.priority: mediumReal value, no hard deadline; normal backlog flow.status: readyTriaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Type

    Fields

    Work status

    agent-ready

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions