Repository navigation
Labels
agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.Fully specified and briefed; eligible for autonomous pickup from the frontier.priority: mediumReal value, no hard deadline; normal backlog flow.Real value, no hard deadline; normal backlog flow.status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.
Description
Parent #7589 decides that pstack's principles are placed "as reasoned sentences in the phase-skill step that applies them" (D58, Q174, Q175). The owner approved this 2026-10-15 (poteto-review decision rows 58 and 105). The wording rule the owner accepted (Q175) is that each placed part states the reason and the test that shows it applies, rather than a bare rule, and names the standard or discipline it comes from.
This slice places these parts:
- 2b and 2g (
boundary-discipline), inreview:code-reviewer: inside a validated boundary, trust the types, with no re-validation and no deep nil checks; the test question is "Is this data crossing a system boundary right now?" The code-reviewer agent (plugins/review/agents/code-reviewer.md:73-80) has the pure-function question at:77but not the boundary one. The implement side landed atplugins/implementation/skills/implement/SKILL.md:52. - 14e (
minimize-reader-load), in the reviewer's mutable-state item: shrink state scope, preferring returns over mutation, locals over fields, and fields over globals. Architecture's scan has it atplugins/architecture/skills/improve/research/deepening/scan-briefing.md:41; the reviewer does not. - 20e (
separate-before-serializing-shared-state), quoted as written in/coupling:reducerung 1 (plugins/coupling/skills/reduce/reference/remediations.md:38-47): "Instructions and conventions are not concurrency control." - 12e (
make-operations-idempotent), in the loop-lane contract: every step that writes to the forge converges when rerun.docs/contracts/loop-lane/README.mdcovers restart adoption (:949) and duplicate-escalation suppression (:518), but has no general rule.
Done when
-
plugins/review/agents/code-reviewer.md's code-quality list gains one item: re-validation or deep nil checks on data that crossed no system boundary, with the question "Is this data crossing a system boundary right now?" and the reason (checks inside a typed boundary add noise and false safety). - The reviewer's mutable-state item names the scope order (returns over mutation, locals over fields over globals), with the reason that a reader must track every place that can change the value.
-
plugins/coupling/skills/reduce/reference/remediations.mdrung 1 carries the sentence "Instructions and conventions are not concurrency control." with one line of reason. When that file has plugin copies listed inscripts/shared-copies.txt, the copies match. -
docs/contracts/loop-lane/README.mdstates that every step that writes to the forge (a label, comment, branch or PR) must leave the same state when rerun after a stop at any point, and that it reads current forge state before writing. It gives the reason: lanes restart and are re-dispatched. When that file has plugin copies listed inscripts/shared-copies.txt, the copies match. -
.changes/review/*.mdand.changes/coupling/*.mdfragments withbump: patchdescribe the additions, plus one for each plugin whose loop-lane copy changed. - The PR's CI is green.
Out of scope
- Gated part 24i (optional-field bags that allow contradictory states): gated per refactor(pstack): cut marginal sections from four skills cursor/plugins#634 (Q557).
- Changing loop-lane behavior or code: this adds a design rule to the contract text only.
Parent: #7589
Metadata
Metadata
Assignees
Labels
agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.Fully specified and briefed; eligible for autonomous pickup from the frontier.priority: mediumReal value, no hard deadline; normal backlog flow.Real value, no hard deadline; normal backlog flow.status: readyTriaged, unblocked, and fully specified; eligible to pick up.Triaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.A briefed fix or small feature; blast radius bounded by the brief, tests exist.
Type
Fields
No fields configured for Feature.
Activity
github-actions commentedon Nov 1, 2026