Repository navigation
fix(skill-quality): track unquoted triggers in check 3 and drop check 12's single-quote rule #11965
Description
Refs #7582
Blocked by: #11954
Outcome
Check 3 protects unquoted Use when triggers, so check 12 no longer needs to warn that triggers are not single-quoted.
Decisions
- D82, Q183, Q184: check 12 drops the single-quote rule. Check 3's unquoted-trigger tracking lands first, in the same PR, with a red-then-green test.
- B2: two attempts ranked on the session-flow trim-pilot diff (from perf(session-flow): run the description trim pilot and measure skill visibility #11954).
Done when
- The check-skill test suite exits 0 and includes a case asserting check 3 warns on a dropped unquoted trigger (no such case on main).
-
rg -c "not single-quoted" plugins/skill-quality/scripts/check-skill.shreturns 0 (nonzero on main), andbash plugins/skill-quality/scripts/check-skill.sh plugins/session-flow/skillsexits 0. - Check 3's unquoted-trigger tracking lands in the same PR as the check 12 change, with a red-then-green test, and the PR records the two attempts ranked on the session-flow trim-pilot diff (B2).
Out of scope
- The description thresholds as settings (sibling slice).
Activity
melodic-automation-lanes commentedon Nov 1, 2026
Not admitted to the issue lane: Size unset is not one of small, medium; Uncertainty unset is not one of known, knowable. Admission takes the issue once each of those is met, when intake triages it again (
.github/actions/resolve-config/admission-rules.json).github-actions commentedon Nov 1, 2026