Repository navigation
feat(work-items): decompose writes why a Done-when check cannot fail at the starting commit #11876
Description
Problem
/work-items:decompose's base-commit check flags a criterion that already passes at the base commit
and asks whether to sharpen it or leave it out. D95 also allows keeping such a check when the item
says why, but nothing writes that reason into the published body, so a picker sees a check that
proves nothing with no explanation.
Origin: D95, Q523.
Fix
When a criterion that cannot fail at the starting commit is kept, decompose writes a one-line reason
beside it in the published Done-when; the approval step offers "keep, with the reason" beside
sharpen and leave out.
Done when
- The decompose skill's base-commit check and body template state the "keep, with the reason" option and where the reason is written.
- A case under
plugins/work-items/evals/with a check already true at base expects it sharpened, left out, or kept with a written reason;python3 plugins/evals/skills/validate/scripts/validate-cases.py plugins/work-items/evalsandbash plugins/skill-quality/scripts/check-skill.sh plugins/work-items/skillsexit 0, andbash scripts/check-changelog-fragments.shpasses with a work-items fragment.
Parent: #7578
Activity
github-actions commentedon Nov 1, 2026
melodic-automation-lanes commentedon Nov 1, 2026
This records a re-fire of an earlier refusal, not a new refusal. The lanes kill switch stopped run 41281709427, the work-resolve-issue run that
agent-readystarted, before it did any work; that run ended at 2026-11-01T09:32:56Z. work-unblock has now removed and addedagent-readyback to start a fresh run. A kill-switch refusal is no fault in this issue or the lanes, so it never counts against later re-fires; after limits.limit-stops-per-issue of them since a person last addedagent-readyor a run last reported, work-unblock waits longer before each one, up to 24 hours.github-actions commentedon Nov 1, 2026
github-actions commentedon Nov 1, 2026