Skip to content

standards: per-concern standards layout - part 1 of 2 #10231

Description

@melodic-automation-lanes

Part 1 of 2 of #7583, split at intake (owner Q93). The done-when below is copied from #7583 as written.

Done when

  • Every per-concern standards file exists and REVIEW.md links each one (the folder does not exist
  • The rule list under AGENTS.md ## Code Review Rules lives in the per-concern files, and AGENTS.md keeps only one pointer line to those files.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 26, 2026
  2. github-actions commented on Oct 26, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Medium
    Complexity: Low
    Uncertainty: Known
    Flags: none
    Blocked by: none

    Understood: move the AGENTS.md Code Review Rules into per-concern files under docs/review/, add an index, and leave one pointer line in AGENTS.md. The recorded decision below settles the open questions, so nothing is asked again. The merge-hold floor change it waited on has merged.

    Decision recorded. Issue Triage session (agent); not an owner decision.

    Admission parked this issue at 20:02Z because merged #12009 names it with Refs:. #12009 did none of this issue's work: it put docs/review/** on the merge-hold floor, which the 16:51Z lane stop needed before this move. The move itself is left. The criteria are unchanged from the earlier record, restated here:

    • docs/review/README.md exists and links REVIEW.md and each per-concern file named in this comment: skills-and-agents.md, cost-claims.md, evals.md, hooks.md, untrusted-content.md, pull-requests.md.
    • Each of the 11 rule bullets under AGENTS.md ## Code Review Rules (every bullet except the REVIEW.md pointer, which the index carries) appears in exactly one of the six per-concern files as a one-line rule with its existing link, and no file copies text from the linked source.
    • AGENTS.md ## Code Review Rules keeps only one pointer line, to docs/review/README.md; the generated instruction-placement rules index that follows the section is unchanged.
    • ADR 0059's REVIEW.md row and ADR 0060's "Code Review Rules list ... loads in every review session" sentence are amended in place to name docs/review/ and the one AGENTS.md pointer line.
    • No REVIEW.md or docs/standards/ file is edited in this repository.

    #10231 (comment)

    No duplicates found.

    Automated triage, applied by the lanes App.

  3. added
    priority: lowNice-to-have, cosmetic, or speculative; opportunistic.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 26, 2026
  4. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.
    on Oct 26, 2026
  5. melodic-automation-lanes commented on Oct 26, 2026

    @melodic-automation-lanes
    ContributorAuthor

    Not admitted to the issue lane: merged pull request #12009 names it with Refs: after its newest decision or refinement comment, so its work may already be done: close the issue if it is, or post a comment whose first line is **Decision recorded.** saying what is left, which sends it back through intake. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).

  6. added
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    on Nov 1, 2026
  7. github-actions commented on Nov 1, 2026

    @github-actions
    Contributor
    No description provided.
  8. 24 remaining items

  9. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.
    and removed
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    on Nov 1, 2026
  10. melodic-automation-lanes commented on Nov 1, 2026

    @melodic-automation-lanes
    ContributorAuthor

    The latest triage verdict holds nothing: the issue is at status: ready.

  11. kyle-sexton commented on Nov 1, 2026

    @kyle-sexton
    Member

    Decision recorded. Issue Triage session (agent); not an owner decision.

    Admission parked this issue at 20:02Z because merged #12009 names it with Refs:. #12009 did none of this issue's work: it put docs/review/** on the merge-hold floor, which the 16:51Z lane stop needed before this move. The move itself is left. The criteria are unchanged from the earlier record, restated here:

    • docs/review/README.md exists and links REVIEW.md and each per-concern file named in this comment: skills-and-agents.md, cost-claims.md, evals.md, hooks.md, untrusted-content.md, pull-requests.md.
    • Each of the 11 rule bullets under AGENTS.md ## Code Review Rules (every bullet except the REVIEW.md pointer, which the index carries) appears in exactly one of the six per-concern files as a one-line rule with its existing link, and no file copies text from the linked source.
    • AGENTS.md ## Code Review Rules keeps only one pointer line, to docs/review/README.md; the generated instruction-placement rules index that follows the section is unchanged.
    • ADR 0059's REVIEW.md row and ADR 0060's "Code Review Rules list ... loads in every review session" sentence are amended in place to name docs/review/ and the one AGENTS.md pointer line.
    • No REVIEW.md or docs/standards/ file is edited in this repository.
  12. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    and removed
    status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 1, 2026
  13. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    on Nov 1, 2026
  14. github-actions commented on Nov 1, 2026

    @github-actions
    Contributor
    No description provided.
  15. melodic-automation-lanes commented on Nov 1, 2026

    @melodic-automation-lanes
    ContributorAuthor

    This run started fresh from the default branch instead of resuming work-resolve-issue/issue-10231-41322493073-1, which is behind it. That branch keeps the earlier run's commits until the next run on this issue deletes it, when no pull request uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.priority: lowNice-to-have, cosmetic, or speculative; opportunistic.status: readyTriaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Type

    Fields

    No fields configured for Task.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions