Skip to content

docs(agents): point the review criteria at the synced REVIEW.md - #117

Merged
kyle-sexton merged 1 commit into
mainfrom
docs/review-md-pointer
Oct 30, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
docs/review-md-pointer

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/standards#726

Summary

REVIEW.md now exists at this repository's root through the review-instructions sync component. The AGENTS.md Code Review Rules pointer still links the canonical URL, so the code-review-rules audit reports it as missing the local link.

Fix

Replace the URL-form pointer with a link to the local REVIEW.md, worded as in the other enrolled repositories. No CI root-coverage or path-classification step in this repository classifies top-level files, so no workflow change is needed.

Verification

  • git diff shows one changed line in AGENTS.md.
  • The audit checker's expected form is the one in the standards#726 plan.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01VcupojYKhHyDni9LuAXBuX

@kyle-sexton
kyle-sexton marked this pull request as ready for review October 30, 2026 21:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T21:45:14.045567Z 673c6c5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 673c6c523f309210e910ee3bb902c3d71a6cc98a: 0 finding(s), 0 as inline comments.

No security findings in PR #117 (head 673c6c5).

The PR changes one line in AGENTS.md. It swaps an absolute link to melodic-software/standards REVIEW.md for a relative link to the in-repo REVIEW.md. That file exists in the checkout.

  • Instruction surface: AGENTS.md is a standing instruction file, so I read the change under the instruction-surface lens. It removes no rule and narrows nothing. The "Code Review Rules" pointer still names the org-wide criteria, and only the link target changed. I did not read the instruction exception register, because the change removes no rule to check against it.
  • Trust controls and trusted paths: the diff touches none of them, and no workflow, action, token, or hold path.
  • Plugin manifests: none changed.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 673c6c523f309210e910ee3bb902c3d71a6cc98a: 0 finding(s), 0 as inline comments.

No findings. The PR changes one line in AGENTS.md: the Code Review Rules pointer now links the local REVIEW.md instead of the canonical URL in melodic-software/standards.

  • I ran ls and git ls-files in the checkout, and REVIEW.md exists at the repository root and is tracked, so the new relative link resolves.
  • The PR body opens with "Refs: code-review-rules: enroll the six URL-form sync targets in review-instructions standards#726" rather than a closing keyword. The linkage rule is advisory, so that is not a finding. No closing issue sections were provided, so there were no acceptance criteria to check.
  • I did not check the PR's claim that the audit checker expects this wording. That claim is author-stated and unverified.
  • No plugin manifests changed, and no security surface is touched.

@kyle-sexton
kyle-sexton merged commit cff7525 into main Oct 30, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the docs/review-md-pointer branch October 30, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant