Repository navigation
docs: point standards links at the renamed standards/ folder - #224
Merged
Merged
Conversation
melodic-software/standards renames its conventions/ folder to standards/, and GitHub does not redirect blob URLs after a rename. Update every reference here to the new path. Refs: melodic-software/standards#790 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcupojYKhHyDni9LuAXBuX
kyle-sexton
added a commit
to melodic-software/standards
that referenced
this pull request
Oct 31, 2026
Closes #790 ## Summary Rename the top-level `conventions/` folder to `standards/`, so the folder name matches the repository name and the `docs/standards/` path every consumer already syncs into. The owner approved the rename on 2026-10-15. ## Fix Two commits, so history follows the move: 1. `refactor: move conventions/ to standards/`: `git mv` only, 56 files, all 100% similarity renames. 2. `refactor: point every reference at standards/`: 88 lines in 24 files (87 path references plus the `standards/README.md` heading). Relative links, absolute `blob/main/conventions/...` URLs inside the moved files, prose paths in `README.md`, `AGENTS.md`, `REVIEW.md`, `distribution/`, `docs/` and component READMEs, and the eight engineering-standards source keys in `distribution/sync-manifest.yml`. After merging main, `.github/trust-path-hold.json` is gone (#931), so its glob edit dropped out with it. Left unchanged on purpose: consumer-side `docs/conventions/...` paths (for example the commit-convention destination), links into `claude-code-plugins/docs/conventions/`, the `github-actions-conventions` component, and every use of "conventions" as an ordinary word. No workflow, lint config or test in this repository names the old folder, so none needed an edit (`git grep` over every tracked file). ## Verification - `bash distribution/sync-manifest.sh validate`: `Manifest valid: 47 components, 14 targets`, before and after. - `bash distribution/sync-manifest.sh plan`, before (origin/main) and after: the set of (target, mode, destination path) triples is identical, 374 rows. The only plan lines that differ are the eight source paths (`conventions/engineering/*.md` to `standards/engineering/*.md`), once for each of the 10 targets that adopt `engineering-standards`. - Destination bytes: the next sync changes content only, at the same paths. Synced files whose text named the old folder now name the new one: `REVIEW.md`, `docs/standards/README.md`, and six of the eight `docs/standards/*.md` files (their `blob/main/...` URLs). - `git grep -nP '(?<![\w-])(?<!docs/)conventions/'` returns nothing. - Every `test:*` and `lint:*` script in `package.json` passes (after `npm ci` in the root, `distribution/` and each component with a lockfile). - `harness/shell/run-tests.sh` over all 41 `*.test.sh` files: 39 pass. `components/go-analysis/go-analysis.test.sh` and `components/ruff/ruff.test.sh` fail identically on an untouched origin/main checkout (local golangci-lint 2.13.2 against a pinned 2.12.2 and a Go 1.27 export-data mismatch; local ruff 0.17.0), so they are local toolchain drift, not this change. ## Related Other repositories that cite standards' `conventions/...` paths. GitHub does not redirect blob URLs after a rename, so each gets a draft PR that lands after this one merges: - [melodic-software/claude-code-plugins#11377](melodic-software/claude-code-plugins#11377): 20 lines in 10 files (ADRs 0003 and 0023, five `docs/contracts/*/README.md`, `docs/migration-playbook.md`, `docs/plugin-philosophy.md`, the attribution audit rubric). - [melodic-software/github-iac#807](melodic-software/github-iac#807): `README.md` and `LabelsGrammarTests.cs` (3 lines). - [melodic-software/provisioning#886](melodic-software/provisioning#886): ADR 0003 (2 blob URLs) and two topic plans (4 lines). - [melodic-software/.github#224](melodic-software/.github#224): `CONTRIBUTING.md` (1 blob URL). - [melodic-software/medley#2257](melodic-software/medley#2257): `docs/conventions/progressive-disclosure.md` (1 blob URL). Not edited: the historical entry in claude-code-plugins `docs/contracts/upstream-drift/CHANGELOG.md`, and dated research notes under `.work/` in medley and knowledge-corpus. azure-iac has no reference. Synced copies update through the normal sync PRs after merge and need no hand edit: `REVIEW.md` in 12 targets, `docs/standards/*` in 10. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01VcupojYKhHyDni9LuAXBuX --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton
marked this pull request as ready for review
October 31, 2026 05:37
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review of PR #224 (head 2c4c8f1): no security issues found. The PR changes one line of I skipped the deep review under skip gate 2 (no security-relevant surface). I did not check the instruction-exception register, because no standing instruction is removed or softened. critical-findings: 0 |
|
claude-review reviewed No findings. The PR changes one URL in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: melodic-software/standards#790
Summary
melodic-software/standards renames its
conventions/folder tostandards/in melodic-software/standards#930.
GitHub does not redirect blob URLs after a folder rename, so links and path
citations to the old folder stop resolving once that PR merges.
Fix
Point the branch-naming link in
CONTRIBUTING.mdatstandards/engineering/naming.md.Merge this after melodic-software/standards#930 merges; before that, the new
paths do not exist yet.
Verification
standards/engineering/naming.mdexists on the standards rename branch.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01VcupojYKhHyDni9LuAXBuX