Skip to content

Conversation

@imdmahajankanika
Copy link

@imdmahajankanika imdmahajankanika commented Oct 22, 2025

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • New Features
    • Added a configuration option to control whether Kubernetes service account tokens are automatically mounted on pods.
    • Allows administrators to enforce stricter security by toggling token availability per deployment.
    • Default is disabled, enabling selective opt-in for workloads that require a mounted token.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Oct 22, 2025

Walkthrough

Adds a new automountServiceAccountToken setting to the Meilisearch Helm chart and manifest, exposing control for whether the ServiceAccount token is automatically mounted; the template, values, and static manifest were updated to include the field (default: false).

Changes

Cohort / File(s) Change Summary
ServiceAccount Token Configuration
charts/meilisearch/templates/serviceaccount.yaml, charts/meilisearch/values.yaml, manifests/meilisearch.yaml
Introduces automountServiceAccountToken. Template now renders automountServiceAccountToken: {{ .Values.serviceAccount.automountServiceAccountToken }} inside the create conditional; values.yaml adds the flag with default false; static manifest sets it to false.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to indentation and Helm templating in charts/meilisearch/templates/serviceaccount.yaml.
  • Verify default and documentation in charts/meilisearch/values.yaml align with chart conventions.
  • Confirm manifests/meilisearch.yaml matches intended static manifest format.

Poem

🐰 I nibble at YAML, tidy and light,
A token now hidden, out of sight,
Values set gently, templates tight,
Quiet changes, hopped in overnight.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'added automountServiceAccountToken flag' directly summarizes the main change: adding a new automountServiceAccountToken configuration flag across the Helm chart and manifests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e16a48c and 6e67e95.

📒 Files selected for processing (1)
  • manifests/meilisearch.yaml (1 hunks)
🔇 Additional comments (1)
manifests/meilisearch.yaml (1)

13-13: The described change does not exist in the codebase.

automountServiceAccountToken does not appear anywhere in the manifest file, the serviceaccount template, or the values configuration. The current ServiceAccount in the manifest contains only metadata (name and labels). The original review comment references a change that is not present in the repository.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

brunoocasali
brunoocasali previously approved these changes Dec 2, 2025
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@brunoocasali
Copy link
Member

@meilisearch sync-manifest

@brunoocasali brunoocasali added this pull request to the merge queue Dec 2, 2025
Merged via the queue into meilisearch:main with commit 0433be5 Dec 2, 2025
1 check passed
brunoocasali added a commit that referenced this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants