-
Notifications
You must be signed in to change notification settings - Fork 4
Configure trusted publishing #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdded a permissions block to the GitHub Actions publish workflow granting Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/publish.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cypress_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/publish.yml (1)
15-18: Addoidc: truetosetup-nodeto enable OIDC authentication.The permissions block grants
id-token: write, andNODE_AUTH_TOKENhas been removed, but thesetup-nodeaction is not configured to use OIDC. Without theoidc: trueparameter, npm won't exchange the GitHub OIDC token for credentials, causing the publish step to fail. This aligns with npm's trusted publishers documentation.- uses: actions/setup-node@v6 with: node-version: 14 registry-url: https://registry.npmjs.org/ + oidc: true
🧹 Nitpick comments (1)
.github/workflows/publish.yml (1)
17-17: Update Node.js version to a supported version.Node.js 14 reached end-of-life in April 2023 and is no longer maintained. Use a currently supported LTS version (e.g., 20 or 22).
node-version: 14 + node-version: 20
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/publish.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: cypress_tests
- GitHub Check: tests-run (Node.js 14)
🔇 Additional comments (1)
.github/workflows/publish.yml (1)
6-8: Permissions block correctly configured for OIDC.The
id-token: writepermission is necessary for OIDC token generation, andcontents: readis required for the checkout action. The permissions follow the principle of least privilege.
Pull Request
What does this PR do?
publish.ymlworkflow to allow generating OIDC tokensPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.