Conversation
tcely
force-pushed
the
test-1587-review-lint-findings
branch
from
September 14, 2026 11:51
ee51c13 to
46d9e42
Compare
tcely
commented
Sep 14, 2026
| self.validate_thread_sharing() | ||
| raw_cursor = self.create_cursor() | ||
| with self.make_cursor(raw_cursor) as cursor: | ||
| cursor.execute('SELECT 1;') |
Collaborator
Author
There was a problem hiding this comment.
I don't believe that we need or actually use this query.
In my opinion, it should be removed in favor of the is_usable check provided by the backend.
Any objections??
tcely
force-pushed
the
test-1587-review-lint-findings
branch
4 times, most recently
from
September 14, 2026 16:22
c7a244d to
a683f6e
Compare
tcely
force-pushed
the
main
branch
2 times, most recently
from
September 14, 2026 21:50
c6f9d05 to
0b8ae78
Compare
chore(lint): safe mechanical fixes
tcely
force-pushed
the
test-1587-review-lint-findings
branch
from
September 14, 2026 22:14
408f7bd to
3792e31
Compare
tcely
commented
Sep 14, 2026
tcely
left a comment
tcely
left a comment
Collaborator
Author
There was a problem hiding this comment.
Conflict resolution adjustments.
Co-authored-by: tcely <tcely@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1587