fix(color-theme): show current theme in dropdown button #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
Contributor
|
@pepelsbey Is this solution what you had in mind? |
caugner
added
the
needs content decision
Member
|
Thank you your help! Unfortunately, we might need to scale back the implementation a little. In the language switcher case, the language name is sufficient to represent what this dropdown is for. I'm afraid in the theme switcher's case, "Light", "Dark", or "OS default" might not look clear enough. Let's keep the "Theme" label and the appropriate icon next to it. In the original issue I filed, I pointed out that the current value is not available for screen readers, and this is the problem we need to address. |
Contributor
Author
|
For sure, all smooth |
Contributor
|
Converting to draft awaiting @pepelsbey's feedback to be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Additional details
Screenshots and screen recordings
Before
After
current-theme-display.mov
Related issues and pull requests
#507