Skip to content

fix: decode U+10FFFF instead of replacing it with U+FFFD #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greymoth-jp wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

fix: decode U+10FFFF instead of replacing it with U+FFFD #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ function getDecodedEntity(
: parseInt(entity.substr(2));

decodeResult =
decodeCode >= 0x10ffff
decodeCode > 0x10ffff
? outOfBoundsChar
: decodeCode > 65535
? fromCodePoint(decodeCode)
Expand Down
9 changes: 9 additions & 0 deletions test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,15 @@ describe('lib', () => {
expect(decode(entity)).toEqual(value);
}
});
it('should decode the maximum code point U+10FFFF instead of replacing it', () => {
const maxCodePoint = String.fromCodePoint(0x10ffff);
expect(decode('')).toEqual(maxCodePoint);
expect(decode('')).toEqual(maxCodePoint);
// round-trip: encode emits a reference that decode must read back
expect(decode(encode(maxCodePoint, {mode: 'nonAscii'}))).toEqual(maxCodePoint);
// code points past the Unicode range stay replaced
expect(decode('�')).toEqual(String.fromCharCode(65533));
});
});
});

Expand Down