Relax trait bounds on State and Superstate associated types #79
Open
Lochlanna wants to merge 1 commit intomdeloof:mainfrom
Open
Relax trait bounds on State and Superstate associated types #79Lochlanna wants to merge 1 commit intomdeloof:mainfrom
Lochlanna wants to merge 1 commit intomdeloof:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When working with generic state machines, you have to specify a bunch of trait bounds:
These bounds are verbose and add significant friction when writing generic code. I realized they're not actually needed at the call sites—they should be enforced at the trait definition level instead.
Solution
By moving the bounds for State and SuperState to the IntoStateMachine trait it makes working with a generic state machine much cleaner!
Now the same code requires only:
Changes
AI Disclosure
I did not use any AI at all for any code changes in this PR. It is completely hand written and tested by me.
I did use AI to review my changes and assist me in writing this description.