feat(mcpp.plugins): 0.5.2, a namespace segment derived by path arithmetic - #374
Merged
Conversation
…etic The island fixture, run on Windows for the first time, put an entry point in `app::kernels::_::image`. A root stated with forward slashes and a directory iterator appending with the preferred separator left `\image` rather than `image`, and the root directory became a namespace segment. The shader lane shares that function and had the defect latent: its Windows fixture keeps every payload in one directory, so a segment was never derived there. The floor stays at mcpp 2026.9.8.1. The CN asset is the same bytes as the GitHub source archive of tag v0.5.2, sha256 d73079f93378f2af6b6513eb6f751d8eace99936b61ff3f5ef786e16a49a8e2a, verified by downloading it back after the upload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes
mcpp-pluginsv0.5.2, merged as45a0443with a green run onmainincluding the two cross-platform runners.The island fixture, run on windows-2022 for the first time, failed to compile with
no member named 'image' in namespace 'island_interface::kernels'.namespace_oftrimmed the base directory off a file's directory as a string; a root stated with forward slashes and a directory iterator appending with the preferred separator left\imagerather thanimage, so the root directory became a namespace segment sanitised to_.The shader lane had this too. The function is shared by both lanes since 0.5.0, and
rules-spirv's Windows fixture keeps every payload in one directory, so a segment was never derived there. The leg that surfaced the defect is not the lane it lives on.Checked before opening: Lua syntax, the three descriptor validators,
mcpp xpkg parse, exactly one["latest"]per platform table (three, all at 0.5.2), and the CN asset fetched back and hashed.