Repository navigation
Add godot-cpp 10.0.0 stable modules and upstream-preserving licensing - #2
Merged
Merged
Conversation
Sunrisepeak
changed the title
Sunrisepeak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to upstream godot-cpp 10.0.0-stable (507ed9d840c01a3c5b2a39af8bb4000bfac30bf5) and expose its original godot:: API as mcpplibs.mwrap.godot_cpp@10.0.0. Use the upstream-default Godot 4.7 API, 64-bit/single precision; distinguish the binding release version from the engine API profile.
The independently reusable compat.godot-cpp provider preserves every upstream file and adds only gen/ output from the unmodified upstream generator. Two independent repacks and both public GitHub/GitCode downloads match SHA256 66aaafb642e7a390482dc381818640b1d0e583da2ef0cc9709214bcd13b68264. Regenerate the module from those stable headers. Upstream moved the float/double hash functions out of line, so remove the obsolete shadow header. Recognize new class attributes/diagnostic macros without pruning real HashSet/List/RBMap/etc. exports; add the observed-declaration regression.
Apply the common Apache-2.0 wrapper policy with mcpp-community attribution. Preserve upstream README/license bytes, inherited notices, explicit deployment and byte-preserving checkout. English and Chinese README layouts agree. All current first-release package versions equal upstream exactly, per explicit user instruction.
Validation: local GCC16 strict module/math/textual-macro tests pass (three programs), declaration regression passes and legacy shim regeneration remains byte-identical. Local LLVM23, header consumption and actual shared extension builds also pass; fresh Linux/macOS/Windows CI remains required; older RC greens do not certify the stable upgrade. The source CI uses explicit candidate namespace views over unchanged descriptors until index publication; installed-index acceptance uses the complete original publication layout. Building the extension or standalone math is not engine-load certification. No mcpp engine changes. Index integration: mcpplibs/mcpp-index#564.
Current candidate:
d06b8d1337b39af4130e0327972348d5eee53d37. Squash-commit CI, source release/mirror verification and published-index installation remain gates.Final self-review at
d06b8d1337b39af4130e0327972348d5eee53d37: all current-head source/native/template workflows pass. The reviewed scope is recorded in the execution ledger: license-only corrections preserve implementation paths; Godot 10.0.0 stable regenerates from its exact upstream/default API with the obsolete shim removed and actual GCC/LLVM/header/extension tests passed. Retained document hashes, attribution, notice deployment, bilingual links and byte-preserving Windows checkout were checked. Earlier implementation tests remain separately recorded. Publication still requires exact squash-commit CI and formal archive/mirror verification.