[Minor] McStas version configuration registry to be read-only #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration per McStas version seems to be used in a few places so I turned it into a
dataclass.In this way, we don't have to always pass the default dictionary to make a new one.
We can simply add a new field with default value in the dataclass.
_get_mcstas_version_settingsmakes sure the registry is sorted before it tries to find the matching setting so now we don't have to worry about the registry being sorted.I made both registry (mapping, dict) object and the dataclass to be read-only so that we can't accidentally mess it up.
In case you want to keep it editable, I added the keyword-only argument that you can pass a registry your self.